[ACQE-4318] Fixing static errors

Author: Keerthana81187

src/Magento/FunctionalTestingFramework/Suite/SuiteGenerator.php

@@ -118,7 +118,6 @@ public function generateAllSuites($testManifest)
                 // if our first element is an array we know that we have split the suites
                 if (is_array($firstElement)) {
                     $this->generateSplitSuiteFromTest($suiteName, $suiteContent);
-
                 }
             } catch (FastFailException $e) {
                 throw $e;
@@ -150,76 +149,75 @@ public function generateSuite($suiteName)
      */
     public function generateTestgroupmembership($testManifest)
     {
-    // Get suits and subsuites data array
-    $suites = $testManifest->getSuiteConfig();
-
-    // Add subsuites array[2nd dimension] to main array[1st dimension] to access it directly later
-    if(!empty($suites)) {
-      foreach ($suites as $subSuites) {
-        if(!empty($subSuites)) {
-          foreach ($subSuites as $subSuiteName => $suiteTestNames) {
-            if (!is_numeric($subSuiteName)) {
-              $suites[$subSuiteName] = $suiteTestNames;
-            } else {
-              continue;
+      // Get suits and subsuites data array
+      $suites = $testManifest->getSuiteConfig();
+
+      // Add subsuites array[2nd dimension] to main array[1st dimension] to access it directly later
+      if (!empty($suites)) {
+        foreach ($suites as $subSuites) {
+          if (!empty($subSuites)) {
+            foreach ($subSuites as $subSuiteName => $suiteTestNames) {
+              if (!is_numeric($subSuiteName)) {
+                $suites[$subSuiteName] = $suiteTestNames;
+              } else {
+                continue;
+              }
             }
           }
         }
       }
-    }
 
-    // Path to groups folder
-    $baseDir = FilePathFormatter::format(TESTS_MODULE_PATH);
-    $path = $baseDir .'_generated/groups';
+      // Path to groups folder
+      $baseDir = FilePathFormatter::format(TESTS_MODULE_PATH);
+      $path = $baseDir .'_generated/groups';
 
-    // Read all group files
-    if (is_dir($path)) {
-      $groupFiles = glob("$path/group*.txt");
-      if ($groupFiles === false) {
-        throw new RuntimeException("glob(): error with '$path'");
+      // Read all group files
+      if (is_dir($path)) {
+        $groupFiles = glob("$path/group*.txt");
+        if ($groupFiles === false) {
+          throw new RuntimeException("glob(): error with '$path'");
+        }
+        sort($groupFiles, SORT_NATURAL);
       }
-      sort($groupFiles, SORT_NATURAL);
-    }
 
-    // Read each file in the reverse order and form an array with groupId as key
-    $groupNumber = 0;
-    $allGroupsContent = array();
-    while(!empty($groupFiles)){
-      $group = array_pop($groupFiles);
-      $allGroupsContent[$groupNumber] = file($group);
-      $groupNumber++;
-    }
+      // Read each file in the reverse order and form an array with groupId as key
+      $groupNumber = 0;
+      $allGroupsContent = [];
+      while (!empty($groupFiles)) {
+        $group = array_pop($groupFiles);
+        $allGroupsContent[$groupNumber] = file($group);
+        $groupNumber++;
+      }
 
-    // Output file path
-    $memberShipFilePath = $baseDir.'_generated/testgroupmembership.txt';
-    $testCaseNumber = 0;
-
-    if(!empty($allGroupsContent)) {
-      foreach ($allGroupsContent as $groupId => $groupInfo) {
-        foreach ($groupInfo as $testName) {
-          // If file has -g then it is test suite
-          if (str_contains($testName, '-g')) {
-            $suitename = explode(" ", $testName);
-            $suitename[1] = trim($suitename[1]);
-
-            if(!empty($suites[$suitename[1]])) {
-              foreach ($suites[$suitename[1]] as $key => $test) {
-                $suiteTest = sprintf('%s:%s:%s:%s', $groupId, $key, $suitename[1], $test);
-                file_put_contents($memberShipFilePath, $suiteTest . PHP_EOL, FILE_APPEND);
+      // Output file path
+      $memberShipFilePath = $baseDir.'_generated/testgroupmembership.txt';
+      $testCaseNumber = 0;
+
+      if (!empty($allGroupsContent)) {
+        foreach ($allGroupsContent as $groupId => $groupInfo) {
+          foreach ($groupInfo as $testName) {
+            // If file has -g then it is test suite
+            if (str_contains($testName, '-g')) {
+              $suitename = explode(" ", $testName);
+              $suitename[1] = trim($suitename[1]);
+
+              if (!empty($suites[$suitename[1]])) {
+                foreach ($suites[$suitename[1]] as $key => $test) {
+                  $suiteTest = sprintf('%s:%s:%s:%s', $groupId, $key, $suitename[1], $test);
+                  file_put_contents($memberShipFilePath, $suiteTest . PHP_EOL, FILE_APPEND);
+                }
               }
             }
+            else {
+              $defaultSuiteTest = sprintf('%s:%s:%s', $groupId, $testCaseNumber, $testName);
+              file_put_contents($memberShipFilePath, $defaultSuiteTest, FILE_APPEND);
+            }
+            $testCaseNumber++;
           }
-          // It is default test group
-          else {
-            $defaultSuiteTest = sprintf('%s:%s:%s', $groupId, $testCaseNumber, $testName);
-            file_put_contents($memberShipFilePath, $defaultSuiteTest, FILE_APPEND);
-          }
-          $testCaseNumber++;
+          $testCaseNumber = 0;
         }
-        $testCaseNumber = 0;
       }
     }
-  }
 
     /**
      * Function which takes a suite name and a set of test names. The function then generates all relevant supporting