Merge pull request #300 from magento-gl/4.3.1-release

 Release Checklist :MFTF  4.3.1 release

Author: KevinBKozan

CHANGELOG.md

@@ -1,5 +1,12 @@
 Magento Functional Testing Framework Changelog
 ================================================
+
+4.3.1
+---------
+### Fixes
+* Fixed cannot bind closure to scope of internal class Exception.
+* Fixed broken Mftf doctor command.
+
 4.3.0
 ---------
 ### Enhancements

composer.json

@@ -2,7 +2,7 @@
     "name": "magento/magento2-functional-testing-framework",
     "description": "Magento2 Functional Testing Framework",
     "type": "library",
-    "version": "4.3.0",
+    "version": "4.3.1",
     "license": "AGPL-3.0",
     "keywords": ["magento", "automation", "functional", "testing"],
     "config": {

composer.lock

@@ -198,7 +198,7 @@ private function runMagentoWebDriverDoctor()
         unset($settings['modules']['config'][$magentoWebDriver]);
 
         $dispatcher = new EventDispatcher();
-        $suiteManager = new SuiteManager($dispatcher, self::SUITE, $settings);
+        $suiteManager = new SuiteManager($dispatcher, self::SUITE, $settings, []);
         try {
             $suiteManager->initialize();
             $this->context = ['Successful'];

src/Magento/FunctionalTestingFramework/Console/DoctorCommand.php

@@ -267,15 +267,12 @@ public function attachExceptionToAllure($exception, $testMethod)
 
         AllureHelper::addAttachmentToCurrentStep($exception, $context . 'Exception');
 
-        //pop suppressed exceptions and attach to allure
-        $change = function () {
-            if ($this instanceof \PHPUnit\Framework\ExceptionWrapper) {
-                return $this->previous;
-            } else {
-                return $this->getPrevious();
-            }
-        };
-        $previousException = $change->call($exception);
+        $previousException = null;
+        if ($exception instanceof \PHPUnit\Framework\ExceptionWrapper) {
+            $previousException = $exception->getPreviousWrapped();
+        } elseif ($exception instanceof \Throwable) {
+            $previousException = $exception->getPrevious();
+        }
 
         if ($previousException !== null) {
             $this->attachExceptionToAllure($previousException, $testMethod);

src/Magento/FunctionalTestingFramework/Extension/TestContextExtension.php

@@ -91,8 +91,8 @@ private function connectToSeleniumServer()
                 $this->capabilities,
                 $this->connectionTimeoutInMs,
                 $this->requestTimeoutInMs,
-                $this->httpProxy,
-                $this->httpProxyPort
+                $this->config['http_proxy'],
+                $this->config['http_proxy_port']
             );
             if (null !== $this->remoteWebDriver) {
                 return;