Skip to content

Commit 42dedf0

Browse files
bohdan-harniukbohdan-harniuk
committed
MFTF-33584: Code refactoring
1 parent 64bbd40 commit 42dedf0

File tree

1 file changed

+143
-121
lines changed

1 file changed

+143
-121
lines changed

‎dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/OperationDefinitionObjectHandlerTest.php‎

Lines changed: 143 additions & 121 deletions
Original file line numberDiff line numberDiff line change
@@ -54,32 +54,36 @@ public function testGetMultipleObjects(): void
5454
* has field
5555
* key=id, value=integer
5656
*/
57-
$mockData = [OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
58-
'testOperationName' => [
59-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
60-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
61-
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
62-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
63-
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
64-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
65-
0 => [
66-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
67-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
68-
],
57+
$mockData = [
58+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
59+
'testOperationName' => [
60+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
61+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
62+
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
63+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
64+
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
65+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
66+
0 => [
67+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
68+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
69+
],
70+
]
71+
],
72+
[
73+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
74+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType2,
75+
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
76+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1/{id}',
77+
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'PUT',
78+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
79+
0 => [
80+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
81+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
82+
],
6983
]
70-
],[
71-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
72-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType2,
73-
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
74-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1/{id}',
75-
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'PUT',
76-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
77-
0 => [
78-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
79-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
80-
],
8184
]
82-
]]];
85+
]
86+
];
8387
$this->mockOperationHandlerWithData($mockData);
8488

8589
//Perform Assertions
@@ -108,21 +112,24 @@ public function testDeprecatedOperation(): void
108112
* has field
109113
* key=id, value=integer
110114
*/
111-
$mockData = [OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
112-
'testOperationName' => [
113-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
114-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
115-
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
116-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
117-
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
118-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
119-
0 => [
120-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
121-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
115+
$mockData = [
116+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
117+
'testOperationName' => [
118+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
119+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
120+
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
121+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
122+
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
123+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
124+
0 => [
125+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => 'id',
126+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => 'integer'
127+
],
122128
],
123-
],
124-
OperationDefinitionObjectHandler::OBJ_DEPRECATED => 'deprecation message'
125-
]]];
129+
OperationDefinitionObjectHandler::OBJ_DEPRECATED => 'deprecation message'
130+
]
131+
]
132+
];
126133
$this->mockOperationHandlerWithData($mockData);
127134

128135
//Perform Assertions
@@ -190,53 +197,60 @@ public function testObjectCreation(): void
190197
* key active, value boolean
191198
*
192199
*/
193-
$mockData = [OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
194-
'testOperationName' => [
195-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $testDataTypeName1,
196-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $testOperationType,
197-
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => $testAuth,
198-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => $testUrl,
199-
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => $testMethod,
200-
OperationDefinitionObjectHandler::ENTITY_OPERATION_SUCCESS_REGEX => $testSuccessRegex,
201-
OperationDefinitionObjectHandler::ENTITY_OPERATION_CONTENT_TYPE => [
202-
0 => [
203-
'value' => $testContentType
204-
]
205-
],
206-
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER => [
207-
0 => [
208-
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER_PARAM => $testHeaderParam,
209-
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER_VALUE => $testHeaderValue,
210-
]
211-
],
212-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM => [
213-
0 => [
214-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM_KEY => 'testUrlParamKey',
215-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM_VALUE => 'testUrlParamValue'
216-
]
217-
],
218-
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT => [
219-
0 => [
220-
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY => $nestedObjectKey,
221-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $nestedObjectType,
222-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
223-
0 => [
224-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey1,
225-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $nestedEntryValue1
226-
],
227-
1 => [
228-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey2,
229-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $nestedEntryValue2,
230-
OperationDefinitionObjectHandler::ENTITY_OPERATION_REQUIRED => $nestedEntryRequired2
231-
],
232-
2 => [
233-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey3,
234-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $nestedEntryValue3
200+
$mockData = [
201+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
202+
'testOperationName' => [
203+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $testDataTypeName1,
204+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $testOperationType,
205+
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => $testAuth,
206+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => $testUrl,
207+
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => $testMethod,
208+
OperationDefinitionObjectHandler::ENTITY_OPERATION_SUCCESS_REGEX => $testSuccessRegex,
209+
OperationDefinitionObjectHandler::ENTITY_OPERATION_CONTENT_TYPE => [
210+
0 => [
211+
'value' => $testContentType
212+
]
213+
],
214+
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER => [
215+
0 => [
216+
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER_PARAM => $testHeaderParam,
217+
OperationDefinitionObjectHandler::ENTITY_OPERATION_HEADER_VALUE => $testHeaderValue,
218+
]
219+
],
220+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM => [
221+
0 => [
222+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM_KEY => 'testUrlParamKey',
223+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL_PARAM_VALUE => 'testUrlParamValue'
224+
]
225+
],
226+
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT => [
227+
0 => [
228+
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY => $nestedObjectKey,
229+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $nestedObjectType,
230+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
231+
0 => [
232+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey1,
233+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE =>
234+
$nestedEntryValue1
235+
],
236+
1 => [
237+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey2,
238+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE =>
239+
$nestedEntryValue2,
240+
OperationDefinitionObjectHandler::ENTITY_OPERATION_REQUIRED =>
241+
$nestedEntryRequired2
242+
],
243+
2 => [
244+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $nestedEntryKey3,
245+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE =>
246+
$nestedEntryValue3
247+
]
235248
]
236249
]
237-
]
238-
],
239-
]]];
250+
],
251+
]
252+
]
253+
];
240254
// Prepare objects to compare against
241255
$field = OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY;
242256
$expectedNestedField = new OperationElement(
@@ -326,32 +340,38 @@ public function testObjectArrayCreation(): void
326340
* objects with key = nestedObjectKey, type = nestedObjectType
327341
* has field with key = nestedFieldKey, value = string
328342
*/
329-
$mockData = [OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
330-
'testOperationName' => [
331-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
332-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
333-
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
334-
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
335-
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
336-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY => [
337-
0 => [
338-
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY => $objectArrayKey,
339-
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT => [
340-
0 => [
341-
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY => $twiceNestedObjectKey,
342-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $twiceNestedObjectType,
343-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
344-
0 => [
345-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY =>
346-
$twiceNestedEntryKey,
347-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE =>
348-
$twiceNestedEntryValue
343+
$mockData = [
344+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
345+
'testOperationName' => [
346+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType1,
347+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType1,
348+
OperationDefinitionObjectHandler::ENTITY_OPERATION_AUTH => 'auth',
349+
OperationDefinitionObjectHandler::ENTITY_OPERATION_URL => 'V1/Type1',
350+
OperationDefinitionObjectHandler::ENTITY_OPERATION_METHOD => 'POST',
351+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY => [
352+
0 => [
353+
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY => $objectArrayKey,
354+
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT => [
355+
0 => [
356+
OperationDefinitionObjectHandler::ENTITY_OPERATION_OBJECT_KEY =>
357+
$twiceNestedObjectKey,
358+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE =>
359+
$twiceNestedObjectType,
360+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
361+
0 => [
362+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY =>
363+
$twiceNestedEntryKey,
364+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE =>
365+
$twiceNestedEntryValue
366+
]
349367
]
350368
]
351369
]
352370
]
353371
]
354-
]]]];
372+
]
373+
]
374+
];
355375
// Prepare Objects to compare against
356376
$twoLevelNestedMetadata = new OperationElement(
357377
$twiceNestedEntryKey,
@@ -418,28 +438,30 @@ public function testLooseJsonCreation(): void
418438
* has array key = arrayKey
419439
* fields of value = string
420440
*/
421-
$mockData = [OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
422-
'testOperationName' => [
423-
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType,
424-
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType,
425-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
426-
0 => [
427-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $entryKey,
428-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $entryValue
429-
]
430-
],
431-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY => [
432-
0 => [
433-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY_KEY => $arrayKey,
434-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY_VALUE => [
435-
0 => [
436-
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $arrayValue
441+
$mockData = [
442+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ROOT_TAG => [
443+
'testOperationName' => [
444+
OperationDefinitionObjectHandler::ENTITY_OPERATION_DATA_TYPE => $dataType,
445+
OperationDefinitionObjectHandler::ENTITY_OPERATION_TYPE => $operationType,
446+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY => [
447+
0 => [
448+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_KEY => $entryKey,
449+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $entryValue
450+
]
451+
],
452+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY => [
453+
0 => [
454+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY_KEY => $arrayKey,
455+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ARRAY_VALUE => [
456+
0 => [
457+
OperationDefinitionObjectHandler::ENTITY_OPERATION_ENTRY_VALUE => $arrayValue
458+
]
437459
]
438460
]
439461
]
440462
]
441463
]
442-
]];
464+
];
443465
// Prepare Objects to assert against
444466
$entry = new OperationElement(
445467
$entryKey,

0 commit comments

Comments
 (0)