MQE-2953 | Fix Code Review Points

Mohit.k.Sharma · Mohit.k.Sharma · commit 4082762101ff · 2022-05-18T10:56:25.000+05:30
diff --git a/src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php b/src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
@@ -821,8 +821,8 @@ public function grabCookieAttributes(string $cookie, array $params = []): array
     {
         $params['name'] = $cookie;
         $cookieArrays = $this->filterCookies($this->webDriver->manage()->getCookies(), $params);
+        $cookieAttributes = [];
         if (is_array($cookieArrays)) { // Microsoft Edge returns null if there are no cookies...
-            $cookieAttributes = [];
             foreach ($cookieArrays as $cookieArray) {
                 if ($cookieArray->getName() === $cookie) {
                     $cookieAttributes['name'] = $cookieArray->getValue();
@@ -838,7 +838,7 @@ public function grabCookieAttributes(string $cookie, array $params = []): array
             }
         }
 
-        return [];
+        return $cookieAttributes;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -821,8 +821,8 @@ public function grabCookieAttributes(string $cookie, array $params = []): array`
`821`	`821`	`{`
`822`	`822`	`$params['name'] = $cookie;`
`823`	`823`	`$cookieArrays = $this->filterCookies($this->webDriver->manage()->getCookies(), $params);`
	`824`	`+ $cookieAttributes = [];`
`824`	`825`	`if (is_array($cookieArrays)) { // Microsoft Edge returns null if there are no cookies...`
`825`		`- $cookieAttributes = [];`
`826`	`826`	`foreach ($cookieArrays as $cookieArray) {`
`827`	`827`	`if ($cookieArray->getName() === $cookie) {`
`828`	`828`	`$cookieAttributes['name'] = $cookieArray->getValue();`
`@@ -838,7 +838,7 @@ public function grabCookieAttributes(string $cookie, array $params = []): array`
`838`	`838`	`}`
`839`	`839`	`}`
`840`	`840`
`841`		`- return [];`
	`841`	`+ return $cookieAttributes;`
`842`	`842`	`}`
`843`	`843`
`844`	`844`	`/**`