33294: Code refactoring after code review

Author: bohdan-harniuk

dev/tests/unit/Magento/FunctionalTestFramework/Allure/AllureHelperTest.php

@@ -106,7 +106,6 @@ public function testAddAttachmentUniqueName(): void
     {
         $expectedData = 'string';
         $expectedCaption = 'caption';
-        $this->mockCopyFile($expectedData, $expectedCaption);
 
         //Prepare Allure lifecycle
         Allure::lifecycle()->fire(new StepStartedEvent('firstStep'));
@@ -146,29 +145,4 @@ private function mockAttachmentWriteEvent(string $filePathOrContents, string $ca
         $instanceProperty->setAccessible(true);
         $instanceProperty->setValue($mockInstance, $mockInstance);
     }
-
-    /**
-     * Mock only file writing mechanism.
-     *
-     * @param string $filePathOrContents
-     * @param string $caption
-     *
-     * @return void
-     */
-    private function mockCopyFile(string $filePathOrContents, string $caption): void
-    {
-        $mockInstance = $this->getMockBuilder(AddUniqueAttachmentEvent::class)
-            ->setConstructorArgs([$filePathOrContents, $caption])
-            ->disallowMockingUnknownTypes()
-            ->onlyMethods(['copyFile'])
-            ->getMock();
-
-        $mockInstance
-            ->method('copyFile')
-            ->willReturn(true);
-
-        $instanceProperty = new ReflectionProperty(AddUniqueAttachmentEvent::class, 'instance');
-        $instanceProperty->setAccessible(true);
-        $instanceProperty->setValue($mockInstance, $mockInstance);
-    }
 }

src/Magento/FunctionalTestingFramework/Allure/Event/AddUniqueAttachmentEvent.php

@@ -7,6 +7,8 @@
 
 namespace Magento\FunctionalTestingFramework\Allure\Event;
 
+use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
+use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
 use Symfony\Component\Mime\MimeTypes;
 use Yandex\Allure\Adapter\AllureException;
 use Yandex\Allure\Adapter\Event\AddAttachmentEvent;
@@ -56,19 +58,6 @@ public function getAttachmentFileName($filePathOrContents, $type): string
         return $this->getOutputFileName($fileSha1, $fileExtension);
     }
 
-    /**
-     * Copies file from one path to another. Wrapper for mocking in unit test.
-     *
-     * @param string $filePath
-     * @param string $outputPath
-     *
-     * @return boolean
-     */
-    public function copyFile(string $filePath, string $outputPath): bool
-    {
-        return copy($filePath, $outputPath);
-    }
-
     /**
      * Unit test helper function.
      *
@@ -93,6 +82,23 @@ public static function getInstance(
         return self::$instance;
     }
 
+    /**
+     * Copies file from one path to another. Wrapper for mocking in unit test.
+     *
+     * @param string $filePath
+     * @param string $outputPath
+     *
+     * @return boolean
+     * @throws TestFrameworkException
+     */
+    private function copyFile(string $filePath, string $outputPath): bool
+    {
+        if (MftfApplicationConfig::getConfig()->getPhase() === MftfApplicationConfig::UNIT_TEST_PHASE) {
+            return true;
+        }
+        return copy($filePath, $outputPath);
+    }
+
     /**
      * Copy of parent private function.
      *