MQE-507: [Action Groups] Strange behavior with argument replacement in selector

- Changed str_replace to preg_replace, regex disallows replacement when the argument is attached to another word (cases like categorySideButton versus category.name)
- Added Verification test for useCase

Author: KevinBKozan

dev/tests/verification/Resources/ActionGroupFunctionalCest.txt

@@ -162,4 +162,15 @@ class ActionGroupFunctionalCest
 		$I->amOnPage("/Jane/Dane.html");
 	}
 
+	/**
+	 * @Parameter(name = "AcceptanceTester", value="$I")
+	 * @param AcceptanceTester $I
+	 * @return void
+	 */
+	public function ArgumentWithSameNameAsElement(AcceptanceTester $I)
+	{
+		$I->seeElement("#element");
+		$I->seeElement("#element .John");
+	}
+
 }

dev/tests/verification/TestModule/ActionGroup/FunctionalActionGroup.xml

@@ -38,4 +38,11 @@
         <see selector="{{SampleSection.oneParamElement(myArg.firstname)}}" mergeKey="see1"/>
         <amOnPage url="{{SamplePage.url(myArg.firstname,myArg.lastname)}}" mergeKey="amOnPage1"/>
     </actionGroup>
+    <actionGroup name="FunctionalActionGroupWithTrickyArgument">
+        <arguments>
+            <argument name="simple" defaultValue="simpleData"/>
+        </arguments>
+        <seeElement mergeKey="see1" selector="{{SampleSection.simpleElement}}"/>
+        <seeElement mergeKey="see2" selector="{{SampleSection.simpleElementOneParam(simple.firstname)}}"/>
+    </actionGroup>
 </config>

dev/tests/verification/TestModule/Cest/ActionGroupFunctionalCest.xml

@@ -67,5 +67,8 @@
                 <argument name="myArg" value="DefaultPerson"/>
             </actionGroup>
         </test>
+        <test name="ArgumentWithSameNameAsElement">
+            <actionGroup ref="FunctionalActionGroupWithTrickyArgument" mergeKey="actionGroup1"/>
+        </test>
     </cest>
 </config>

dev/tests/verification/TestModule/Section/SampleSection.xml

@@ -10,6 +10,7 @@
         xsi:noNamespaceSchemaLocation="../../../../../src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
     <section name="SampleSection">
         <element name="simpleElement" type="button" selector="#element"/>
+        <element name="simpleElementOneParam" type="button" selector="#element .{{var1}}" parameterized="true"/>
         <element name="oneParamElement" type="button" selector="#element .{{var1}}" parameterized="true"/>
         <element name="twoParamElement" type="button" selector="#{{var1}} .{{var2}}" parameterized="true"/>
         <element name="threeParamElement" type="button" selector="#{{var1}}-{{var2}} .{{var3}}" parameterized="true"/>

src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php

@@ -217,7 +217,8 @@ private function replaceAttributeArgumentInVariable(
             );
         }
 
-        return  str_replace($variableName, $arguments[$variableName], $attributeValue);
+        //replace argument ONLY when there is no letters attached before after (ex. category.name vs categoryTreeButton)
+        return preg_replace("/(?<![\w]){$variableName}(?![(\w])/", $arguments[$variableName], $attributeValue);
     }
 
     /**