Merge pull request #117 from magento-commerce/imported-magento-magento2-functional-testing-framework-870

[Imported] Removing the `csharpru/vault-php-guzzle6-transport` not needed dependency

Author: jilu1

composer.json

@@ -23,7 +23,7 @@
         "codeception/module-webdriver": "^1.0",
         "composer/composer": "^1.9||^2.0",
         "csharpru/vault-php": "^4.2.1",
-        "csharpru/vault-php-guzzle6-transport": "^2.0",
+        "guzzlehttp/guzzle": "^7.3.0",
         "hoa/console": "~3.0",
         "monolog/monolog": "^2.3",
         "mustache/mustache": "~2.5",

composer.lock

@@ -6,12 +6,12 @@
 
 namespace Magento\FunctionalTestingFramework\DataGenerator\Handlers\SecretStorage;
 
+use GuzzleHttp\Client as GuzzleClient;
 use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
 use Magento\FunctionalTestingFramework\DataGenerator\Handlers\CredentialStore;
 use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
 use Magento\FunctionalTestingFramework\Util\Logger\LoggingUtil;
 use Vault\Client;
-use VaultTransports\Guzzle6Transport;
 
 class VaultStorage extends BaseStorage
 {
@@ -78,8 +78,14 @@ public function __construct($baseUrl, $secretBasePath)
     {
         parent::__construct();
         if (null === $this->client) {
-            // Creating the client using Guzzle6 Transport and passing a custom url
-            $this->client = new Client(new Guzzle6Transport(['base_uri' => $baseUrl]));
+            // client configuration and override http errors settings
+            $config = [
+                'timeout' => 15,
+                'base_uri' => $baseUrl,
+                'http_errors' => false
+            ];
+
+            $this->client = new Client(new GuzzleClient($config));
             $this->secretBasePath = $secretBasePath;
         }
         $this->readVaultTokenFromFileSystem();