MQE-1676: Add a static-check that ensures action groups do not have unused arguments

fixed unit tests

Author: soumyau

src/Magento/FunctionalTestingFramework/StaticCheck/ActionGroupArgumentsCheck.php

@@ -128,7 +128,8 @@ private function buildUnusedArgumentList($actionGroups)
     }
 
     /**
-     * @param $actionGroupXml
+     * Returns unused arguments in an action group
+     * @param string $actionGroupXml
      * @return array
      */
     private function findUnusedArguments($actionGroupXml)
@@ -171,8 +172,9 @@ private function findUnusedArguments($actionGroupXml)
      */
     private function isParentActionGroupArgument($argument, $actionGroup)
     {
-        if ($actionGroup->getParentName() !== null) {
-            $parentActionGroup = ActionGroupObjectHandler::getInstance()->getObject($actionGroup->getParentName());
+        $parentActionGroupName = $actionGroup->getParentName();
+        if ($parentActionGroupName !== null) {
+            $parentActionGroup = ActionGroupObjectHandler::getInstance()->getObject($parentActionGroupName);
             $parentArguments = $parentActionGroup->getArguments();
             foreach ($parentArguments as $parentArgument) {
                 if ($argument === $parentArgument->getName()) {

src/Magento/FunctionalTestingFramework/StaticCheck/StaticCheckHelper.php

@@ -38,7 +38,7 @@ public static function printErrorsToFile($errors, $filename, $message)
 
     /**
      * Builds list of all XML files in given modulePaths + path given
-     * @param array $modulePaths
+     * @param array  $modulePaths
      * @param string $path
      * @return Finder
      */
@@ -53,5 +53,4 @@ public static function buildFileList($modulePaths, $path)
         }
         return $finder->files();
     }
-
 }