Merge branch 'master' into 2.5.0-RC

Author: KevinBKozan

CHANGELOG.md

@@ -37,6 +37,11 @@ Magento Functional Testing Framework Changelog
 ### GitHub Issues/Pull requests:
 * [#377](https://github.com/magento/magento2-functional-testing-framework/pull/377) -- Non-API operations fixes
 
+2.4.5
+-----
+### Fixes
+* Fixed an issue where `.credentials` was required when using `<createData>` actions with field overrides.
+
 2.4.4
 -----
 ### Fixes

docs/actiongroup-list.md

@@ -0,0 +1,6 @@
+# MFTF action group reference
+
+Action groups are important building blocks for quickly creating tests for the Magento Functional Testing Framework.
+This page lists all current action groups so developers can see what is available to them.
+
+{% include mftf/actiongroup_data.md %}

docs/selectors.md

@@ -0,0 +1,35 @@
+## Selectors
+
+These guidelines should help you to write high quality selectors.
+
+### Selectors SHOULD be written in CSS instead of XPath whenever possible
+
+CSS is generally easier to read than XPath. For example, `//*[@id="foo"]` in XPath can be expressed as simply as `#foo` in CSS.
+See this [XPath Cheatsheet](https://devhints.io/xpath) for more examples.
+
+### XPath selectors SHOULD NOT use `@attribute="foo"`. 
+
+This would fail if the attribute was `attribute="foo bar"`.
+Instead you SHOULD use `contains(@attribute, "foo")` where `@attribute` is any valid attribute such as `@text` or `@class`.
+
+### CSS and XPath selectors SHOULD be implemented in their most simple form
+
+* <span class="color:green">GOOD:</span> `#foo`
+* <span class="color:red">BAD:</span> `button[contains(@id, "foo")]`
+
+### CSS and XPath selectors SHOULD avoid making use of hardcoded indices
+
+Instead you SHOULD parameterize the selector.
+
+* <span class="color:green">GOOD:</span> `.foo:nth-of-type({{index}})`
+* <span class="color:red">BAD:</span> `.foo:nth-of-type(1)`
+
+* <span class="color:green">GOOD:</span> `button[contains(@id, "foo")][{{index}}]`
+* <span class="color:red">BAD:</span> `button[contains(@id, "foo")][1]`
+
+* <span class="color:green">GOOD:</span> `#actions__{{index}}__aggregator`
+* <span class="color:red">BAD:</span> `#actions__1__aggregator`
+
+### CSS and XPath selectors MUST NOT reference the `@data-bind` attribute
+
+The `@data-bind` attribute is used by KnockoutJS, a framework Magento uses to create dynamic Javascript pages. Since this `@data-bind` attribute is tied to a specific framework, it should not be used for selectors. If Magento decides to use a different framework then these `@data-bind` selectors would break.

src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/PersistedObjectHandler.php

@@ -89,7 +89,12 @@ public function createEntity(
         }
 
         foreach ($overrideFields as $index => $field) {
-            $overrideFields[$index] = CredentialStore::getInstance()->decryptAllSecretsInString($field);
+            try {
+                $overrideFields[$index] = CredentialStore::getInstance()->decryptAllSecretsInString($field);
+            } catch (TestFrameworkException $e) {
+                //do not rethrow if Credentials are not defined
+                $overrideFields[$index] = $field;
+            }
         }
 
         $retrievedEntity = DataObjectHandler::getInstance()->getObject($entity);