MQE-2195: refactored mftf svc code and incorporated in magento-semver repo

Author: jilu1

src/Analyzer/Mftf/ActionGroupAnalyzer.php

@@ -67,14 +67,15 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                 $afterArguments = [];
                 $afterActions = [];
 
-                foreach ($beforeEntity['value'] as $beforeChild) {
+                foreach ($beforeEntity['value'] ?? [] as $beforeChild) {
                     if ($beforeChild['name'] == self::MFTF_ARGUMENTS_ELEMENT) {
                         $beforeArguments = $beforeChild['value'];
                     } else {
                         $beforeActions[] = $beforeChild;
                     }
                 }
-                foreach ($afterEntities[$module][$entityName]['value'] as $afterChild) {
+
+                foreach ($afterEntities[$module][$entityName]['value'] ?? [] as $afterChild) {
                     if ($afterChild['name'] == self::MFTF_ARGUMENTS_ELEMENT) {
                         $afterArguments = $afterChild['value'];
                     } else {
@@ -84,7 +85,6 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
 
                 // Validate <actions>
                 foreach ($beforeActions as $testAction) {
-                    // Action group annotations, continue
                     if (!isset($testAction['attributes']['stepKey'])) {
                         continue;
                     }

src/Analyzer/Mftf/DataAnalyzer.php

@@ -77,7 +77,7 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                 $afterReqFields = [];
                 $afterArrayFields = [];
 
-                foreach ($beforeEntity['value'] as $beforeChild) {
+                foreach ($beforeEntity['value'] ?? [] as $beforeChild) {
                     if ($beforeChild['name'] == self::MFTF_DATA_FIELD_ELEMENT) {
                         $beforeDataFields[] = $beforeChild;
                     } elseif ($beforeChild['name'] == self::MFTF_VAR_ELEMENT) {
@@ -89,7 +89,7 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                     }
                 }
 
-                foreach ($afterEntities[$module][$entityName]['value'] as $afterChild) {
+                foreach ($afterEntities[$module][$entityName]['value'] ?? [] as $afterChild) {
                     if ($afterChild['name'] == self::MFTF_DATA_FIELD_ELEMENT) {
                         $afterDataFields[] = $afterChild;
                     } elseif ($afterChild['name'] == self::MFTF_VAR_ELEMENT) {

src/Analyzer/Mftf/PageAnalyzer.php

@@ -60,17 +60,12 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                 $beforeSectionElements = [];
                 $afterSectionElements = [];
 
-                // Continue when page does not have sections
-                if (!isset($beforeEntity['value'])) {
-                    continue;
-                }
-
-                foreach ($beforeEntity['value'] as $beforeChild) {
+                foreach ($beforeEntity['value'] ?? [] as $beforeChild) {
                     if ($beforeChild['name'] == self::MFTF_SECTION_ELEMENT) {
                         $beforeSectionElements[] = $beforeChild;
                     }
                 }
-                foreach ($afterEntities[$module][$entityName]['value'] as $afterChild) {
+                foreach ($afterEntities[$module][$entityName]['value'] ?? [] as $afterChild) {
                     if ($afterChild['name'] == self::MFTF_SECTION_ELEMENT) {
                         $afterSectionElements[] = $afterChild;
                     }

src/Analyzer/Mftf/SectionAnalyzer.php

@@ -60,12 +60,12 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                 $beforeElements = [];
                 $afterElements = [];
 
-                foreach ($beforeEntity['value'] as $beforeChild) {
+                foreach ($beforeEntity['value'] ?? [] as $beforeChild) {
                     if ($beforeChild['name'] == self::MFTF_ELEMENT_ELEMENT) {
                         $beforeElements[] = $beforeChild;
                     }
                 }
-                foreach ($afterEntities[$module][$entityName]['value'] as $afterChild) {
+                foreach ($afterEntities[$module][$entityName]['value'] ?? [] as $afterChild) {
                     if ($afterChild['name'] == self::MFTF_ELEMENT_ELEMENT) {
                         $afterElements[] = $afterChild;
                     }

src/Analyzer/Mftf/TestAnalyzer.php

@@ -172,6 +172,9 @@ public function validateActionsInBlock(
         $operationTarget
     ) {
         foreach ($beforeTestActions as $testAction) {
+            if (!isset($testAction['attributes']['stepKey'])) {
+                continue;
+            }
             $beforeFieldKey = $testAction['attributes']['stepKey'];
             $matchingElement = $this->findMatchingElement($testAction, $afterTestActions,'stepKey');
             if ($matchingElement === null) {