added constant for analyzer context

Author: akaplya

src/Analyzer/EtSchemaAnalyzer.php

@@ -18,6 +18,15 @@
  */
 class EtSchemaAnalyzer implements AnalyzerInterface
 {
+
+    /**
+     * Analyser context
+     */
+    const CONTEXT = 'etSchema';
+
+    /**
+     * @var array of actions
+     */
     private static $actions = [
         'addedRecord' => [
             'level' => Level::MINOR,
@@ -46,11 +55,6 @@ class EtSchemaAnalyzer implements AnalyzerInterface
         ]
     ];
 
-    /**
-     * @var string
-     */
-    private $context = 'etSchema';
-
     /**
      * @var Report
      */
@@ -304,7 +308,7 @@ public function reportChanges(array $changes): void
     {
         foreach ($changes as $change) {
             $this->report->add(
-                $this->context,
+                self::CONTEXT,
                 new EtSchemaOperation(
                 $change['location'],
                 $change['code'],
@@ -327,16 +331,16 @@ public function analyze($registryBefore, $registryAfter)
     {
         $changes = [];
         $commonModules = array_intersect(
-            array_keys($registryBefore->data['etSchema']),
-            array_keys($registryAfter->data['etSchema'])
+            array_keys($registryBefore->data[self::CONTEXT]),
+            array_keys($registryAfter->data[self::CONTEXT])
         );
         foreach ($commonModules as $moduleName) {
             $changes = array_merge(
                 $changes,
                 $this->analyzeModuleConfig(
                     $moduleName,
-                    $registryBefore->data['etSchema'][$moduleName],
-                    $registryAfter->data['etSchema'][$moduleName]
+                    $registryBefore->data[self::CONTEXT][$moduleName],
+                    $registryAfter->data[self::CONTEXT][$moduleName]
                 )
             );
         }
@@ -345,11 +349,11 @@ public function analyze($registryBefore, $registryAfter)
             $changes,
             $this->removedModuleConfig(
                 array_intersect_key(
-                    $registryBefore->data['etSchema'],
+                    $registryBefore->data[self::CONTEXT],
                     array_flip(
                         array_diff(
-                            array_keys($registryBefore->data['etSchema']),
-                            array_keys($registryAfter->data['etSchema'])
+                            array_keys($registryBefore->data[self::CONTEXT]),
+                            array_keys($registryAfter->data[self::CONTEXT])
                         )
                     )
                 )
@@ -360,11 +364,11 @@ public function analyze($registryBefore, $registryAfter)
             $changes,
             $this->addedModuleConfig(
                 array_intersect_key(
-                    $registryAfter->data['etSchema'],
+                    $registryAfter->data[self::CONTEXT],
                     array_flip(
                         array_diff(
-                            array_keys($registryAfter->data['etSchema']),
-                            array_keys($registryBefore->data['etSchema'])
+                            array_keys($registryAfter->data[self::CONTEXT]),
+                            array_keys($registryBefore->data[self::CONTEXT])
                         )
                     )
                 )
@@ -375,4 +379,4 @@ public function analyze($registryBefore, $registryAfter)
         $this->reportChanges($changes);
         return $this->report;
     }
-}
+}

src/DbSchemaReport.php

@@ -8,6 +8,7 @@
 
 use PHPSemVerChecker\Report\Report as ReportAlias;
 use PHPSemVerChecker\SemanticVersioning\Level;
+use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
 
 class DbSchemaReport extends ReportAlias
 {
@@ -24,6 +25,6 @@ public function __construct()
         $this->differences['system'] = $levels;
         $this->differences['xsd'] = $levels;
         $this->differences['less'] = $levels;
-        $this->differences['etSchema'] = $levels;
+        $this->differences[EtSchemaAnalyzer::CONTEXT] = $levels;
     }
 }

src/DbSchemaReporter.php

@@ -8,6 +8,7 @@
 
 use Magento\SemanticVersionChecker\Reporter\TableReporter;
 use Symfony\Component\Console\Output\OutputInterface;
+use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
 
 /**
  * Class DbSchemaReporter
@@ -30,6 +31,6 @@ public function output(OutputInterface $output)
         $this->outputReport($output, $this->report, 'system');
         $this->outputReport($output, $this->report, 'xsd');
         $this->outputReport($output, $this->report, 'less');
-        $this->outputReport($output, $this->report, 'etSchema');
+        $this->outputReport($output, $this->report, EtSchemaAnalyzer::CONTEXT);
     }
 }

src/ReportTypes.php

@@ -9,6 +9,7 @@
 
 namespace Magento\SemanticVersionChecker;
 
+use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
 /**
  * Holds the different report type keys.
  */
@@ -22,5 +23,5 @@ class ReportTypes
     public const SYSTEM_XML = 'systemXml';
     public const XSD        = 'xsd';
     public const LESS       = 'less';
-    public const ET_SCHEMA  = 'etSchema';
+    public const ET_SCHEMA  = EtSchemaAnalyzer::CONTEXT;
 }

src/Reporter/HtmlDbSchemaReporter.php

@@ -14,7 +14,7 @@
 use PHPSemVerChecker\SemanticVersioning\Level;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-
+use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
 /**
  * @package Magento\SemanticVersionChecker
  */
@@ -61,7 +61,7 @@ public function output(OutputInterface $output)
             'system',
             'xsd',
             'less',
-            'etSchema'
+            EtSchemaAnalyzer::CONTEXT
         ];
 
         foreach ($contexts as $context) {

src/Scanner/EtSchemaScanner.php

@@ -10,6 +10,7 @@
 use Magento\SemanticVersionChecker\Registry\XmlRegistry;
 use Magento\SemanticVersionChecker\Scanner\EtSchema\XmlConverter;
 use PHPSemVerChecker\Registry\Registry;
+use Magento\SemanticVersionChecker\Analyzer\EtSchemaAnalyzer;
 
 /**
  * Class EtSchemaScanner
@@ -57,7 +58,7 @@ public function scan(string $file): void
         $doc->loadXML(file_get_contents($file));
         $moduleName = $this->getModuleNameByPath->resolveByEtcDirFilePath($file);
         $data = $this->converter->convert($doc);
-        $this->getRegistry()->data['etSchema'][$moduleName] = $data;
+        $this->getRegistry()->data[EtSchemaAnalyzer::CONTEXT][$moduleName] = $data;
     }
 
     /**