ACP2E-932: [Infra] Integrate EAT and Jenkins SVC

Author: victor-v-rad

dev/tests/Unit/Reporter/HtmlTargetDecoratorTest.php

@@ -10,10 +10,15 @@ class HtmlTargetDecoratorTest extends TestCase
     /**
      * @dataProvider dataProviderTestUrl
      */
-    public function testUrl(string $target, string $context, string $urlJson, string $expected): void
+    public function testUrl(bool $hasOption, string $target, string $context, string $urlJson, string $expected): void
     {
         $input = $this->getMockBuilder(InputInterface::class)->getMockForAbstractClass();
-        $input->expects($this->once())->method('getOption')->with('report-html-target-url')->willReturn($urlJson);
+        $input->expects($this->once())->method('hasOption')->with('report-html-target-url')->willReturn($hasOption);
+        if ($hasOption) {
+            $input->expects($this->once())->method('getOption')->with('report-html-target-url')->willReturn($urlJson);
+        } else {
+            $input->expects($this->never())->method('getOption');
+        }
         $result = HtmlTargetDecorator::url($target, $context, $input);
         $this->assertEquals($expected, $result);
     }
@@ -22,35 +27,47 @@ public function dataProviderTestUrl()
     {
         return [
             'target-context-class' => [
+                true,
                 'Magento\Framework\Registry',
                 'class',
                 '[{"reportTypes": ["interface", "class"], "url": "https://localhost/?target=%s"}]',
                 '<a href="https://localhost/?target=TWFnZW50b1xGcmFtZXdvcmtcUmVnaXN0cnk=" target="_blank">Magento\Framework\Registry</a>'
             ],
             'target-context-class-array' => [
+                true,
                 'Magento\Framework\Registry',
                 'class',
                 '[{"reportTypes": ["mftf"], "url": "https://localhost/?target=%s"}, {"reportTypes": ["class"], "url": "https://localhost/?target=%s"}]',
                 '<a href="https://localhost/?target=TWFnZW50b1xGcmFtZXdvcmtcUmVnaXN0cnk=" target="_blank">Magento\Framework\Registry</a>'
             ],
             'target-context-mftf' => [
+                true,
                 'Magento\Framework\Registry',
                 'mftf',
                 '[{"reportTypes": ["interface", "class"], "url": "https://localhost/?target=%s"}]',
                 'Magento\Framework\Registry'
             ],
             'empty-json' => [
-                'Magento\Framework\Registry',
+                true,
+                'Magento\Framework\Registry::$someProperty',
                 'class',
                 '',
-                'Magento\Framework\Registry'
+                'Magento\Framework\Registry::$someProperty'
             ],
             'broken-json' => [
+                true,
                 'Magento\Framework\Registry',
                 'class',
                 '[{"reportTypes": ["interface", "class"]',
                 'Magento\Framework\Registry'
             ],
+            'has-no-option' => [
+                false,
+                'Magento\Framework\Registry',
+                'class',
+                '',
+                'Magento\Framework\Registry'
+            ],
         ];
     }
 }

src/Reporter/HtmlTargetDecorator.php

@@ -9,6 +9,8 @@
  */
 class HtmlTargetDecorator
 {
+    private static string $optionName = 'report-html-target-url';
+
     /**
      * Create a link tag for specific report types
      *
@@ -19,7 +21,10 @@ class HtmlTargetDecorator
      */
     public static function url(string $target, string $context, InputInterface $input): string
     {
-        $urlContextJson = $input->getOption('report-html-target-url');
+        if (!$input->hasOption(self::$optionName)) {
+            return $target;
+        }
+        $urlContextJson = $input->getOption(self::$optionName);
         foreach (@json_decode($urlContextJson, true) ?? [] as $urlContext) {
             if (!in_array($context, $urlContext['reportTypes']) || !$urlContext['url']) {
                 continue;