MQE-2247: Implement additional <section> and <operation> entity use cases in SVC tool

Added use case for parameterized attribute added

Author: soumyau

src/Analyzer/Mftf/SectionAnalyzer.php

@@ -24,6 +24,7 @@ class SectionAnalyzer extends AbstractEntityAnalyzer
     const MFTF_ELEMENT_ELEMENT = "{}element";
     const MFTF_DATA_TYPE = 'section';
     const MFTF_DATA_DIRECTORY = '/Mftf/Section/';
+    const MFTF_ELEMENT_PARAM = 'parameterized';
 
     /**
      * operations array
@@ -34,7 +35,7 @@ class SectionAnalyzer extends AbstractEntityAnalyzer
         AbstractEntityAnalyzer::DEFAULT_OPERATION_KEY => SectionElementChanged::class,
         'selector' => SectionElementSelectorChanged::class,
         'type' => SectionElementTypeChanged::class,
-        'parameterized' => SectionElementParameterizedChanged::class
+        self::MFTF_ELEMENT_PARAM => SectionElementParameterizedChanged::class
     ];
 
     /**
@@ -109,6 +110,20 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
                             self::$operations,
                             "$operationTarget/$beforeFieldKey"
                         );
+
+                        // validate parameterized added
+                        $beforeAttributes = $beforeField['attributes'];
+                        $afterAttributes =  $matchingElement['attributes'];
+
+                        if (isset($afterAttributes[self::MFTF_ELEMENT_PARAM])) {
+                            if (!isset($beforeAttributes[self::MFTF_ELEMENT_PARAM])) {
+                                $operation = new SectionElementParameterizedChanged(
+                                    $filenames,
+                                    "$operationTarget/$beforeFieldKey/". self::MFTF_ELEMENT_PARAM
+                                );
+                                $this->getReport()->add(MftfReport::MFTF_REPORT_CONTEXT, $operation);
+                            }
+                        }
                     }
                 }
                 $this->findAddedElementsInArray(

tests/Unit/Console/Command/CompareSourceCommandMftfTest.php

@@ -442,9 +442,18 @@ public function changesDataProvider()
                 ],
                 'Patch change is detected.'
             ],
-            'section-element-parameterized-changed' => [
-                $pathToFixtures . '/section-element-parameterized-changed/source-code-before',
-                $pathToFixtures . '/section-element-parameterized-changed/source-code-after',
+            'section-element-parameterized-added' => [
+                $pathToFixtures . '/section-element-parameterized-added/source-code-before',
+                $pathToFixtures . '/section-element-parameterized-added/source-code-after',
+                [
+                    'Mftf (MAJOR)',
+                    'Section/SampleSection/element1/parameterized | <section> <element> parameterized was changed | M250'
+                ],
+                'Major change is detected.'
+            ],
+            'section-element-parameterized-removed' => [
+                $pathToFixtures . '/section-element-parameterized-removed/source-code-before',
+                $pathToFixtures . '/section-element-parameterized-removed/source-code-after',
                 [
                     'Mftf (MAJOR)',
                     'Section/SampleSection/element1/parameterized | <section> <element> parameterized was changed | M250'

tests/Unit/Console/Command/CompareSourceCommandTest/_files/mftf/section-element-parameterized-changed/source-code-before/Magento/TestModule/Test/Mftf/section.xml renamed to tests/Unit/Console/Command/CompareSourceCommandTest/_files/mftf/section-element-parameterized-added/source-code-after/Magento/TestModule/Test/Mftf/section.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+    <section name="SampleSection">
+        <element name="element1" type="block" selector="span:nth-of-type({{var}})"/>
+    </section>
+</sections>

tests/Unit/Console/Command/CompareSourceCommandTest/_files/mftf/section-element-parameterized-changed/source-code-after/Magento/TestModule/Test/Mftf/section.xml renamed to tests/Unit/Console/Command/CompareSourceCommandTest/_files/mftf/section-element-parameterized-added/source-code-before/Magento/TestModule/Test/Mftf/section.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+    <section name="SampleSection">
+        <element name="element1" type="block" selector="span:nth-of-type({{var}})" parameterized="true"/>
+    </section>
+</sections>