MAGETWO-99387: Prohibit usage of native htmlspecialchars()

Author: davemacaulay

Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php

@@ -218,5 +218,6 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
         '^is_null$' => 'strict comparison "=== null"',
         '^intval$' => '(int) construction',
         '^strval$' => '(string) construction',
+        '^htmlspecialchars$' => '\Magento\Framework\Escaper->escapeHtml',
     ];
 }

Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc

@@ -462,3 +462,5 @@ $int = intval($int);
 $str = chop($text, 'ttt');
 
 md5($text);
+
+htmlspecialchars('text');

Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php

@@ -249,6 +249,7 @@ public function getWarningList()
             458 => 1,
             460 => 1,
             462 => 1,
+            466 => 1
         ];
     }
 }