AC-667: Create phpcs static check for EmailTemplateTest

Author: jcuerdo

Magento2/Sniffs/Legacy/EmailTemplateSniff.php

@@ -19,7 +19,7 @@ class EmailTemplateSniff implements Sniff
         '/\{\{escapehtml.*?\}\}/i' => 'Directive {{escapehtml}} is obsolete. Use {{var}} instead.',
     ];
 
-    private const WARNING_CODE = 'FoundObsoleteEmailDirective';
+    private const ERROR_CODE = 'FoundObsoleteEmailDirective';
 
     /**
      * @inheritdoc
@@ -39,10 +39,10 @@ public function process(File $phpcsFile, $stackPtr)
         $content = $phpcsFile->getTokens()[$stackPtr]['content'];
         foreach (self::OBSOLETE_EMAIL_DIRECTIVES as $directiveRegex => $errorMessage) {
             if (preg_match($directiveRegex, $content)) {
-                $phpcsFile->addWarning(
+                $phpcsFile->addError(
                     $errorMessage,
                     $stackPtr,
-                    self::WARNING_CODE
+                    self::ERROR_CODE
                 );
             }
         }

Magento2/Tests/Legacy/EmailTemplateUnitTest.php

@@ -13,15 +13,7 @@ class EmailTemplateUnitTest extends AbstractSniffUnitTest
     /**
      * @inheritdoc
      */
-    public function getErrorList()
-    {
-        return [];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function getWarningList($testFile = '')
+    public function getErrorList($testFile = '')
     {
         if ($testFile === 'EmailTemplateUnitTest.1.html') {
             return [];
@@ -36,4 +28,12 @@ public function getWarningList($testFile = '')
 
         return [];
     }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList($testFile = '')
+    {
+        return [];
+    }
 }

Magento2/ruleset.xml

@@ -241,12 +241,11 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
-
     <rule ref="Magento2.Legacy.EmailTemplate.FoundObsoleteEmailDirective">
         <include-pattern>view/email/*.html</include-pattern>
         <include-pattern>view/*/email/*.html</include-pattern>
         <severity>8</severity>
-        <type>warning</type>
+        <type>error</type>
     </rule>
 
     <!-- Severity 7 warnings: General code issues. -->