#319: Corrected regex

Author: sivaschenko

Magento2/Sniffs/PHP/AutogeneratedClassNotInConstructorSniff.php

@@ -142,14 +142,10 @@ private function getObjectManagerVariableName(File $phpcsFile, int $stackPtr): ?
      */
     private function getRequestedClass(File $phpcsFile, int $callerPosition): ?string
     {
-        if (!isset($phpcsFile->getTokens()[$callerPosition + 10])) {
-            return null;
-        }
-
         $matches = [];
         $found = preg_match(
-            '/->(get|create)\(([A-Za-z]+)::class/',
-            $phpcsFile->getTokensAsString($callerPosition, 7),
+            '/->(get|create)\(([A-Za-z\\\]+)::class/',
+            $phpcsFile->getTokensAsString($callerPosition, $phpcsFile->findNext(T_CLOSE_PARENTHESIS, $callerPosition)),
             $matches
         );
 

Magento2/Tests/PHP/AutogeneratedClassNotInConstructorUnitTest.2.php.inc

@@ -32,6 +32,9 @@ class Bad
         $this->eavSetup = $objectManager
             ->get(EavSetupFactory::class)
             ->create(['setup' => $this->setup]);
+
+        ObjectManager::getInstance()
+            ->get(\Full\Class\NameFactory::class);
     }
 }
 

Magento2/Tests/PHP/AutogeneratedClassNotInConstructorUnitTest.php

@@ -26,7 +26,8 @@ public function getErrorList($filename = '')
             return [
                 22 => 1,
                 28 => 1,
-                33 => 1
+                33 => 1,
+                37 => 1
             ];
         }
         return [];