AC-665: Create phpcs static check for ConfigTest

Author: svera

Magento2/Sniffs/Legacy/ObsoleteConfigNodesSniff.php

@@ -49,12 +49,8 @@ public function process(File $phpcsFile, $stackPtr)
                 self::ERROR_CODE_CONFIG
             );
         }
-        $obsoleteNodes = [];
-        $obsoleteNodesFiles = glob(__DIR__ . '/_files/obsolete_config_nodes*.php');
-        foreach ($obsoleteNodesFiles as $obsoleteNodesFile) {
-            $obsoleteNodes = array_merge($obsoleteNodes, include $obsoleteNodesFile);
-        }
-        foreach ($obsoleteNodes as $xpath => $suggestion) {
+
+        foreach ($this->getObsoleteNodes() as $xpath => $suggestion) {
             $matches = $xml->xpath($xpath);
             if (empty($matches)) {
                 continue;
@@ -87,4 +83,19 @@ private function getFormattedXML(File $phpcsFile)
         return $doc->saveXML();
     }
 
+    /**
+     * Get a list of obsolete nodes
+     *
+     * @return array
+     */
+    private function getObsoleteNodes(): array
+    {
+        $obsoleteNodes = [];
+        $obsoleteNodesFiles = glob(__DIR__ . '/_files/obsolete_config_nodes*.php');
+        foreach ($obsoleteNodesFiles as $obsoleteNodesFile) {
+            $obsoleteNodes = array_merge($obsoleteNodes, include $obsoleteNodesFile);
+        }
+        return $obsoleteNodes;
+    }
+
 }