#21 Review Fixes

Lars Roettig · Lars Roettig · commit d49b390f4a6b · 2019-04-07T15:24:55.000+02:00
diff --git a/Magento2/Sniffs/Exceptions/TryProcessSystemResourcesSniff.php b/Magento2/Sniffs/Exceptions/TryProcessSystemResourcesSniff.php
@@ -3,7 +3,6 @@
  * Copyright © Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 namespace Magento2\Sniffs\Exceptions;
 
 use function array_slice;
@@ -20,7 +19,7 @@ class TryProcessSystemResourcesSniff implements Sniff
      *
      * @var string
      */
-    protected $warningMessage = 'All resources SHOULD be properly released.';
+    protected $warningMessage = 'The code MUST be wrapped with a try block if the method uses system resources .';
 
     /**
      * Warning violation code.
diff --git a/Magento2/Tests/Exceptions/TryProcessSystemResourcesUnitTest.inc b/Magento2/Tests/Exceptions/TryProcessSystemResourcesUnitTest.inc
@@ -6,7 +6,7 @@ use Exception;
 
 class StreamHandler
 {
-    public function handleExpection()
+    public function handleException()
     {
         try {
             $strChar = stream_get_contents(STDIN, 1);
@@ -15,7 +15,7 @@ class StreamHandler
         }
     }
 
-    public function exetcute()
+    public function execute()
     {
         // Rule find: Try block detected when processing system resources
         $strChar = stream_get_contents(STDIN, 1);
diff --git a/output.txt b/output.txt

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ use Exception;`
`6`	`6`
`7`	`7`	`class StreamHandler`
`8`	`8`	`{`
`9`		`- public function handleExpection()`
	`9`	`+ public function handleException()`
`10`	`10`	`{`
`11`	`11`	`try {`
`12`	`12`	`$strChar = stream_get_contents(STDIN, 1);`
`@@ -15,7 +15,7 @@ class StreamHandler`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`- public function exetcute()`
	`18`	`+ public function execute()`
`19`	`19`	`{`
`20`	`20`	`// Rule find: Try block detected when processing system resources`
`21`	`21`	`$strChar = stream_get_contents(STDIN, 1);`