AC-1549: Added more codes and cleaned up unused messages

Author: svera

Magento2/Sniffs/Legacy/InstallUpgradeSniff.php

@@ -13,8 +13,6 @@
 
 class InstallUpgradeSniff implements Sniff
 {
-    private const ERROR_CODE = 'invalidDirectory';
-
     /**
      * @var string[]
      */
@@ -52,6 +50,14 @@ class InstallUpgradeSniff implements Sniff
         'recurring' => 'obsoleteRecurringScript',
     ];
 
+    /**
+     * @var string[]
+     */
+    private $invalidDirectoriesErrorCodes = [
+        'data' => 'dataInvalidDirectory',
+        'sql' => 'sqlInvalidDirectory'
+    ];
+
     /**
      * @inheritdoc
      */
@@ -88,7 +94,7 @@ public function process(File $phpcsFile, $stackPtr)
                 . "- Create a data patch within module's Setup/Patch/Data folder for data upgrades.\n"
                 . "- Use declarative schema approach in module's etc/db_schema.xml file for schema changes.",
                 0,
-                self::ERROR_CODE
+                $this->invalidDirectoriesErrorCodes[$folderName]
             );
         }
     }

Magento2/Sniffs/Legacy/ObsoleteConnectionSniff.php

@@ -12,8 +12,6 @@
 
 class ObsoleteConnectionSniff implements Sniff
 {
-    private const ERROR_CODE_METHOD = 'FoundObsoleteMethod';
-
     /**
      * @var string[]
      */

Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php

@@ -12,7 +12,6 @@
 
 class PhtmlTemplateSniff implements Sniff
 {
-    private const WARNING_CODE = 'PhtmlTemplateObsolete';
     private const WARNING_CODE_TEXT_JAVASCRIPT = 'TextJavascriptTypeFound';
     private const WARNING_CODE_THIS_USAGE = 'ThisUsageObsolete';
     private const WARNING_CODE_PROTECTED_PRIVATE_BLOCK_ACCESS = 'ProtectedPrivateBlockAccess';