ACP2E-2977: Implement Static test which will check for no usage of object manager in .phtml files

Author: veloraven

Magento2/Sniffs/Phtml/PhtmlTemplateObjectManagerSniff.php renamed to Magento2/Sniffs/Templates/ObjectManagerSniff.php

@@ -16,17 +16,17 @@
  */
 declare(strict_types = 1);
 
-namespace Magento2\Sniffs\Phtml;
+namespace Magento2\Sniffs\Templates;
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
 
 /**
- * Class PhtmlTemplateObjectManagerSniff
- *
  * Templates must not instantiate new objects within their code.
  * All objects must be passed from the Block object.
  *
+ * @see https://developer.adobe.com/commerce/php/coding-standards/technical-guidelines/#62-presentation-layer 6.2.6
+ * @link https://developer.adobe.com/commerce/frontend-core/guide/layouts/xml-instructions/#obtain-arguments-examples-in-template
  * @link https://developer.adobe.com/commerce/frontend-core/guide/templates/override/#getting-argument-values-from-layout
  */
 class PhtmlTemplateObjectManagerSniff implements Sniff

Magento2/Tests/Phtml/PhtmlTemplateObjectManager.1.phtml.inc renamed to Magento2/Tests/Templates/ObjectManager.1.phtml

@@ -0,0 +1,25 @@
+<?php
+/************************************************************************
+ *
+ * Copyright 2024 Adobe
+ * All Rights Reserved.
+ *
+ * NOTICE: All information contained herein is, and remains
+ * the property of Adobe and its suppliers, if any. The intellectual
+ * and technical concepts contained herein are proprietary to Adobe
+ * and its suppliers and are protected by all applicable intellectual
+ * property laws, including trade secret and copyright laws.
+ * Dissemination of this information or reproduction of this material
+ * is strictly forbidden unless prior written permission is obtained
+ * from Adobe.
+ * **********************************************************************
+ */
+
+    $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
+?>
+
+<div class="block test">
+</div>
+<script type="jquery/ui">
+</script>
+

Magento2/Tests/Templates/ObjectManager.1.phtml.inc

@@ -350,7 +350,7 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento2.Phtml.PhtmlTemplateObjectManager">
+    <rule ref="Magento2.Templates.ObjectManager">
         <include-pattern>*\.phtml$</include-pattern>
         <severity>8</severity>
         <type>warning</type>