Merge pull request #178 from magento-commerce/imported-loginesta-magento-coding-standard-393

[Imported] AC-3098: Update hasDeprecatedWellFormatted

Author: loginesta

Magento2/Helpers/Commenting/PHPDocFormattingValidator.php

@@ -121,15 +121,11 @@ public function hasDeprecatedWellFormatted($commentStartPtr, $tokens)
         if ($deprecatedPtr === -1) {
             return true;
         }
-
-        $seeTagRequired = false;
-        if ($tokens[$deprecatedPtr + 2]['code'] !== T_DOC_COMMENT_STRING) {
-            $seeTagRequired = true;
-        }
         $seePtr = $this->getTagPosition('@see', $commentStartPtr, $tokens);
         if ($seePtr === -1) {
-            return !$seeTagRequired;
+            return false;
         }
+
         return $tokens[$seePtr + 2]['code'] === T_DOC_COMMENT_STRING;
     }
 

Magento2/Tests/Commenting/ClassAndInterfacePHPDocFormattingUnitTest.php

@@ -33,6 +33,7 @@ public function getWarningList($testFile = '')
             65 => 1,
             66 => 1,
             101 => 1,
+            109 => 1,
             118 => 1,
             127 => 1,
         ];

Magento2/Tests/Commenting/ConstantsPHPDocFormattingUnitTest.1.inc

@@ -7,11 +7,6 @@ define('DS', DIRECTORY_SEPARATOR);
 
 define('BP', dirname(__FILE__));
 
-/**
- * @deprecated It is a lie
- */
-define('THERE IS', 'cake');
-
 /**
  * @deprecated New implementation available
  * @see \Ascii\Asterisk
@@ -27,11 +22,6 @@ class Profiler
      */
     const NUMBER_TWO = 2;
 
-    /**
-     * @deprecated Why not
-     */
-    const YES = false;
-
     /**
      * @deprecated Unable to identify the question, replaced
      * @see \ComputationalMatrix\Earth

Magento2/Tests/Commenting/ConstantsPHPDocFormattingUnitTest.2.inc

@@ -13,6 +13,11 @@ define('NUMBER_ONE', 1);
  */
 define('A', 65);
 
+/**
+ * @deprecated It is a lie
+ */
+define('THERE IS', 'cake');
+
 /**
  * @deprecated
  * @see
@@ -42,6 +47,11 @@ class Profiler
      */
     const a = 97;
 
+    /**
+     * @deprecated Why not
+     */
+    const YES = false;
+
     /**
      * @deprecated
      * @see

Magento2/Tests/Commenting/ConstantsPHPDocFormattingUnitTest.php

@@ -30,13 +30,15 @@ public function getWarningList($testFile = '')
             6 => 1,
             9 => 1,
             14 => 1,
-            20 => 1,
-            26 => 1,
-            33 => 1,
+            19 => 1,
+            25 => 1,
+            31 => 1,
             38 => 1,
             43 => 1,
-            49 => 1,
-            55 => 1
+            48 => 1,
+            53 => 1,
+            59 => 1,
+            65 => 1
         ];
     }
 }

composer.json

@@ -14,7 +14,7 @@
         "ext-dom": "*",
         "phpcompatibility/php-compatibility": "^9.3",
         "squizlabs/php_codesniffer": "^3.6.1",
-        "rector/rector": "^0.12.17"
+        "rector/rector": "^0.13.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5.8"