AC-1549: Made suggestions

Author: svera

Magento2/Sniffs/Legacy/ObsoleteConnectionSniff.php

@@ -16,16 +16,18 @@ class ObsoleteConnectionSniff implements Sniff
      * @var string[]
      */
     private $obsoleteMethods = [
-        '_getReadConnection' => 'FoundObsoleteMethod_getReadConnection',
-        '_getWriteConnection' => 'FoundObsoleteMethod_getWriteConnection',
-        '_getReadAdapter' => 'FoundObsoleteMethod_getReadAdapter',
-        '_getWriteAdapter' => 'FoundObsoleteMethod_getWriteAdapter',
-        'getReadConnection' => 'FoundObsoleteMethodGetReadConnection',
-        'getWriteConnection' => 'FoundObsoleteMethodGetWriteConnection',
-        'getReadAdapter' => 'FoundObsoleteMethodGetReadAdapter',
-        'getWriteAdapter' => 'FoundObsoleteMethodGetWriteAdapter',
+        '_getReadConnection',
+        '_getWriteConnection',
+        '_getReadAdapter',
+        '_getWriteAdapter',
+        'getReadConnection',
+        'getWriteConnection',
+        'getReadAdapter',
+        'getWriteAdapter',
     ];
 
+    private const OBSOLETE_METHOD_ERROR_CODE = 'ObsoleteMethodFound';
+
     /**
      * @inheritdoc
      */
@@ -56,12 +58,12 @@ private function validateObsoleteMethod(File $phpcsFile, int $stackPtr)
         $tokens = $phpcsFile->getTokens();
         $stringPos = $phpcsFile->findNext(T_STRING, $stackPtr + 1);
 
-        foreach ($this->obsoleteMethods as $method => $errorCode) {
+        foreach ($this->obsoleteMethods as $method) {
             if ($tokens[$stringPos]['content'] === $method) {
                 $phpcsFile->addWarning(
                     sprintf("Contains obsolete method: %s. Please use getConnection method instead.", $method),
                     $stackPtr,
-                    $errorCode
+                    self::OBSOLETE_METHOD_ERROR_CODE
                 );
             }
         }