AC-662: Create phpcs static check for AutogeneratedClassNotInConstructorTest

Author: jcuerdo

Magento2/Sniffs/PHP/AutogeneratedClassNotInConstructorSniff.php

@@ -60,10 +60,9 @@ public function process(File $phpcsFile, $stackPtr)
             }
 
             if (!$this->isVariableInConstructorParameters($phpcsFile, $equalsPtr, $statementEnd)) {
-                $next = $stackPtr;
-                $className = $this->obtainClassToGetOrCreate($phpcsFile, $next, $statementEnd);
+                $className = $this->obtainClassToGetOrCreate($phpcsFile, $stackPtr, $statementEnd);
 
-                $phpcsFile->addWarning(
+                $phpcsFile->addError(
                     sprintf("Class %s needs to be requested in constructor, " .
                         "otherwise compiler will not be able to find and generate these classes", $className),
                     $stackPtr,
@@ -182,6 +181,8 @@ protected function variableName(string $parameterName): string
     }
 
     /**
+     * Checks if a variable is present in the constructor parameters
+     *
      * @param File $phpcsFile
      * @param int $equalsPtr
      * @param int $statementEnd
@@ -205,12 +206,14 @@ private function isVariableInConstructorParameters(File $phpcsFile, int $equalsP
     }
 
     /**
+     * Obtain the class inside ObjectManager::getInstance()->get|create()
+     *
      * @param File $phpcsFile
-     * @param $next
+     * @param int $next
      * @param int $statementEnd
      * @return string
      */
-    private function obtainClassToGetOrCreate(File $phpcsFile, $next, int $statementEnd): string
+    private function obtainClassToGetOrCreate(File $phpcsFile, int $next, int $statementEnd): string
     {
         while ($next = $phpcsFile->findNext(T_DOUBLE_COLON, $next + 1, $statementEnd)) {
             if ($this->getNext($phpcsFile, $next, $statementEnd, T_STRING)['content'] === 'class') {

Magento2/Tests/PHP/AutogeneratedClassNotInConstructorUnitTest.php

@@ -14,7 +14,7 @@ class AutogeneratedClassNotInConstructorUnitTest extends AbstractSniffUnitTest
     /**
      * @inheritdoc
      */
-    public function getWarningList($filename = '')
+    public function getErrorList($filename = '')
     {
         if ($filename === 'AutogeneratedClassNotInConstructorUnitTest.1.php.inc') {
             return [
@@ -32,7 +32,7 @@ public function getWarningList($filename = '')
     /**
      * @inheritdoc
      */
-    public function getErrorList()
+    public function getWarningList($filename = '')
     {
         return [];
     }

Magento2/ruleset.xml

@@ -115,6 +115,11 @@
         <severity>10</severity>
         <type>error</type>
     </rule>
+    <rule ref="Magento2.PHP.AutogeneratedClassNotInConstructor">
+        <include-pattern>*\.php$</include-pattern>
+        <severity>10</severity>
+        <type>error</type>
+    </rule>
 
     <!-- Severity 9 warnings: Possible security and issues that may cause bugs. -->
     <rule ref="Generic.Files.ByteOrderMark">