AC-2222: [UCT Autofixing] PHPCompatibility.ForbiddenFinalPrivateMethods

Author: svera

Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.inc

@@ -1,21 +1,27 @@
 <?php
 
-class CrossVersionInValid
+final class CrossVersionInValid
 {
     private final function __construct() {}
     final private function privateFinal();
     static private final function privateStaticFinal();
+    static protected final function protectedStaticFinal();
+    final protected function protectedFinal();
 }
 
 $anon = new class() {
     private final function __construct() {}
     final private function privateFinal();
     static final private function privateStaticFinal();
+    final protected function protectedFinal();
+    static final protected function protectedStaticFinal();
 };
 
 trait CrossVersionInValidTrait
 {
     private final function __construct() {}
     final private function privateFinal();
+    final protected function protectedFinal();
     static private final function privateStaticFinal();
+    static protected final function protectedStaticFinal();
 }

Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.inc.fixed

@@ -1,21 +1,27 @@
 <?php
 
-class CrossVersionInValid
+final class CrossVersionInValid
 {
     private final function __construct() {}
     private function privateFinal();
     static private function privateStaticFinal();
+    static protected final function protectedStaticFinal();
+    final protected function protectedFinal();
 }
 
 $anon = new class() {
     private final function __construct() {}
     private function privateFinal();
     static private function privateStaticFinal();
+    final protected function protectedFinal();
+    static final protected function protectedStaticFinal();
 };
 
 trait CrossVersionInValidTrait
 {
     private final function __construct() {}
     private function privateFinal();
+    final protected function protectedFinal();
     static private function privateStaticFinal();
+    static protected final function protectedStaticFinal();
 }

Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.php

@@ -40,10 +40,10 @@ public function getWarningList()
        return [
             6 => 1,
             7 => 1,
-            12 => 1,
-            13 => 1,
-            19 => 1,
-            20 => 1,
+            14 => 1,
+            15 => 1,
+            23 => 1,
+            25 => 1,
         ];
     }
 }