#121 HelperInTemplate Rule porposal amends

Author: diazwatson

Magento2/Sniffs/Templates/HelperInTemplateSniff.md

@@ -14,6 +14,10 @@ Replace `$this` with `$block`. If you use private or protected methods, make the
 
 ---
 
+# Rule: Do not use `helpers` in templates
+## Background
+The use of helpers is in general discouraged. For template files, consider using a ViewModel instead.
+
 ## Reasoning
 The use of helpers is in general discouraged therefore any `$this->helper(<helper_class>)` code used in PHTML templates should be refactored.
 
@@ -23,7 +27,7 @@ Consider using ViewModel instead.
 
 Typical example of a helper being used in a PHTML:
 ```html
-<?php $_incl = $block->helper(<helper_class>)->...; ?>
+<?php $_incl = $this->helper(<helper_class>)->...; ?>
 ```
 
 Once the ViewModel is created, call it in the PHTML as follow:

Magento2/Sniffs/Templates/HelperInTemplateSniff.php

@@ -3,6 +3,7 @@
  * Copyright © Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento2\Sniffs\Templates;
 
 use PHP_CodeSniffer\Sniffs\Sniff;
@@ -18,14 +19,28 @@ class ThisInTemplateSniff implements Sniff
      *
      * @var string
      */
-    protected $warningMessage = 'Usage of $this in template files is deprecated.';
+    protected $warningMessageFoundHelper = 'Usage of helpers in templates is discouraged.';
+
+    /**
+     * Warning violation code.
+     *
+     * @var string
+     */
+    protected $warningCodeFoundHelper = 'FoundHelper';
+
+    /**
+     * String representation of warning.
+     *
+     * @var string
+     */
+    protected $warningMessageFoundThis = 'Usage of $this in template files is deprecated.';
 
     /**
      * Warning violation code.
      *
      * @var string
      */
-    protected $warningCode = 'FoundThis';
+    protected $warningCodeFoundThis = 'FoundThis';
 
     /**
      * @inheritdoc
@@ -42,7 +57,10 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
         if ($tokens[$stackPtr]['content'] === '$this') {
-            $phpcsFile->addWarning($this->warningMessage, $stackPtr, $this->warningCode);
+            $phpcsFile->addWarning($this->warningMessageFoundThis, $stackPtr, $this->warningCodeFoundThis);
+        }
+        if ($tokens[$stackPtr]['content'] === 'helper(') {
+            $phpcsFile->addWarning($this->warningMessageFoundHelper, $stackPtr, $this->warningCodeFoundHelper);
         }
     }
 }