AC-679: Create phpcs static check for ObsoleteSystemConfigurationTest

eliseacornejo · eliseacornejo · commit 5148a61664b1 · 2021-09-29T17:26:26.000+02:00
diff --git a/Magento2/Sniffs/Legacy/ObsoleteSystemConfigurationSniff.php b/Magento2/Sniffs/Legacy/ObsoleteSystemConfigurationSniff.php
@@ -15,7 +15,10 @@ class ObsoleteSystemConfigurationSniff implements Sniff
 {
     private const ERROR_CODE_XML = 'WrongXML';
     private const WARNING_CODE_OBSOLETE = 'FoundObsoleteSystemConfiguration';
-    
+
+    /**
+     * @inheritdoc
+     */
     public function register()
     {
         return [
@@ -85,4 +88,4 @@ private function getFormattedXML(File $phpcsFile)
         $doc->loadXML($phpcsFile->getTokensAsString(0, 999999));
         return $doc->saveXML();
     }
-}
+}
diff --git a/Magento2/Tests/Legacy/ObsoleteSystemConfigurationUnitTest.1.xml b/Magento2/Tests/Legacy/ObsoleteSystemConfigurationUnitTest.1.xml
@@ -8,4 +8,4 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_file.xsd">
     <sections>test sections</sections>
     <tabs>test tabs</tabs>    
-</config>
+</config>
diff --git a/Magento2/Tests/Legacy/ObsoleteSystemConfigurationUnitTest.2.xml b/Magento2/Tests/Legacy/ObsoleteSystemConfigurationUnitTest.2.xml
@@ -12,4 +12,4 @@
         <section id="admin">
         </section>
     </system>
-</config>
+</config>

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,10 @@ class ObsoleteSystemConfigurationSniff implements Sniff`
`15`	`15`	`{`
`16`	`16`	`private const ERROR_CODE_XML = 'WrongXML';`
`17`	`17`	`private const WARNING_CODE_OBSOLETE = 'FoundObsoleteSystemConfiguration';`
`18`		`-`
	`18`	`+`
	`19`	`+ /**`
	`20`	`+ * @inheritdoc`
	`21`	`+ */`
`19`	`22`	`public function register()`
`20`	`23`	`{`
`21`	`24`	`return [`
`@@ -85,4 +88,4 @@ private function getFormattedXML(File $phpcsFile)`
`85`	`88`	`$doc->loadXML($phpcsFile->getTokensAsString(0, 999999));`
`86`	`89`	`return $doc->saveXML();`
`87`	`90`	`}`
`88`		`-}`
	`91`	`+}`