29: [New Rule] Exceptions handling

Lars Roettig · Lars Roettig · commit 4da03239735e · 2019-02-28T11:25:22.000+01:00
diff --git a/Magento/Sniffs/Functions/ThrowCatchSniff.php b/Magento/Sniffs/Functions/ThrowCatchSniff.php
@@ -92,4 +92,4 @@ public function process(File $phpcsFile, $stackPtr)
             }
         }
     }
-}
+}
diff --git a/Magento/Tests/Functions/ThrowCatchUnitTest.inc b/Magento/Tests/Functions/ThrowCatchUnitTest.inc
@@ -157,4 +157,4 @@ $d = function ($data) {
         // Rule find: Exceptions MUST NOT handled in same function
         // handle $exception code
     }
-};
+};
diff --git a/Magento/Tests/Functions/ThrowCatchUnitTest.php b/Magento/Tests/Functions/ThrowCatchUnitTest.php
@@ -34,4 +34,4 @@ protected function getWarningList()
             156 => 1
         ];
     }
-}
+}
diff --git a/Magento/ruleset.xml b/Magento/ruleset.xml
@@ -72,7 +72,7 @@
     <rule ref="Magento.Exceptions.Namespace">
         <severity>8</severity>
     </rule>
-    <rule ref="Magento.Functions.ThrowCatchSniff">
+    <rule ref="Magento.Functions.ThrowCatch">
         <severity>8</severity>
     </rule>
     <rule ref="Magento.Functions.StaticFunction">

Original file line number	Diff line number	Diff line change
`@@ -92,4 +92,4 @@ public function process(File $phpcsFile, $stackPtr)`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`	`}`
`95`		`-}`
	`95`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -157,4 +157,4 @@ $d = function ($data) {`
`157`	`157`	`// Rule find: Exceptions MUST NOT handled in same function`
`158`	`158`	`// handle $exception code`
`159`	`159`	`}`
`160`		`-};`
	`160`	`+};`
Original file line number	Diff line number	Diff line change
`@@ -34,4 +34,4 @@ protected function getWarningList()`
`34`	`34`	`156 => 1`
`35`	`35`	`];`
`36`	`36`	`}`
`37`		`-}`
	`37`	`+}`