#107: [New Rule] Implement sniff for constants PHPDoc formatting

- added strict comparison
- changed sequence in the ruleset.xml

Author: lenaorobei

Magento2/Sniffs/Commenting/ConstantsPHPDocFormattingSniff.php

@@ -31,8 +31,8 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
-        if ($tokens[$stackPtr]['code'] != T_CONST
-            && !($tokens[$stackPtr]['content'] == 'define' && $tokens[$stackPtr+1]['code'] == T_OPEN_PARENTHESIS)
+        if ($tokens[$stackPtr]['code'] !== T_CONST
+            && !($tokens[$stackPtr]['content'] === 'define' && $tokens[$stackPtr + 1]['code'] === T_OPEN_PARENTHESIS)
         ) {
             return;
         }

Magento2/ruleset.xml

@@ -44,10 +44,6 @@
         <severity>10</severity>
         <type>error</type>
     </rule>
-    <rule ref="Magento2.Commenting.ConstantsPHPDocFormatting">
-        <severity>5</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Magento2.PHP.FinalImplementation">
         <severity>10</severity>
         <type>error</type>
@@ -500,6 +496,10 @@
     </rule>
 
     <!-- Severity 5 warnings: PHPDoc formatting and commenting issues. -->
+    <rule ref="Magento2.Commenting.ConstantsPHPDocFormatting">
+        <severity>5</severity>
+        <type>warning</type>
+    </rule>
     <rule ref="Squiz.Commenting.DocCommentAlignment">
         <severity>5</severity>
         <type>warning</type>