AC-662: Create phpcs static check for AutogeneratedClassNotInConstructorTest

Author: jcuerdo

Magento2/Sniffs/PHP/AutogeneratedClassNotInConstructorSniff.php

@@ -11,7 +11,7 @@
 use PHP_CodeSniffer\Sniffs\Sniff;
 
 /**
- * Detects possible usage of 'var' language construction.
+ * Detects bad usages of ObjectManager in constructor.
  */
 class AutogeneratedClassNotInConstructorSniff implements Sniff
 {
@@ -104,13 +104,10 @@ private function isObjectManagerGetInstance(File $phpcsFile, int $stackPtr): boo
     {
         $prev = $phpcsFile->findPrevious(T_STRING, $stackPtr - 1);
         $next = $phpcsFile->findNext(T_STRING, $stackPtr + 1);
-        if ($prev &&
+        return $prev &&
             $next &&
             $phpcsFile->getTokens()[$prev]['content'] === 'ObjectManager' &&
-            $phpcsFile->getTokens()[$next]['content'] === 'getInstance') {
-            return true;
-        }
-        return false;
+            $phpcsFile->getTokens()[$next]['content'] === 'getInstance';
     }
 
     /**