Refactor

Author: loginesta

Magento2/Sniffs/Functions/FunctionsDeprecatedWithoutArgumentSniff.php

@@ -36,7 +36,7 @@ class FunctionsDeprecatedWithoutArgumentSniff implements Sniff
      * @var array
      */
     private const DEPRECATED_FUNCTIONS_AND_FIXES = [
-        'mb_check_encoding' => '\'\'',
+        'mb_check_encoding' => '[]',
         'get_class' => '$this',
         'get_parent_class' => '$this'
     ];

Magento2/Tests/Functions/FunctionsDeprecatedWithoutArgumentUnitTest.inc

@@ -21,11 +21,11 @@ class FunctionsDeprecatedWithoutArgument
     {
         return [
             mb_check_encoding(), // Calling without argument is deprecated.
-            mb_check_encoding('test-argument', null),
+            mb_check_encoding('test-argument'),
             get_class(), // Calling without argument is deprecated.
             get_class(new FunctionsDeprecatedWithoutArgument()),
             get_parent_class(), // Calling without argument is deprecated.
-            get_parent_class('test-argument')
+            get_parent_class(new FunctionsDeprecatedWithoutArgument())
         ];
     }
 }

Magento2/Tests/Functions/FunctionsDeprecatedWithoutArgumentUnitTest.inc.fixed

@@ -20,12 +20,12 @@ class FunctionsDeprecatedWithoutArgument
     public function testDeprecatedMethod(): array
     {
         return [
-            mb_check_encoding(''), // Calling without argument is deprecated.
-            mb_check_encoding('test-argument', null),
+            mb_check_encoding([]), // Calling without argument is deprecated.
+            mb_check_encoding('test-argument'),
             get_class($this), // Calling without argument is deprecated.
             get_class(new FunctionsDeprecatedWithoutArgument()),
             get_parent_class($this), // Calling without argument is deprecated.
-            get_parent_class('test-argument')
+            get_parent_class(new FunctionsDeprecatedWithoutArgument())
         ];
     }
 }