MCLOUD-11659: Add php 8.3 to magento-cloud-docker

Author: BaDos

composer.json

@@ -26,7 +26,7 @@
         "codeception/module-rest": "^1.2",
         "consolidation/robo": "^1.2 || ^2.0",
         "phpmd/phpmd": "@stable",
-        "phpstan/phpstan": "^0.12",
+        "phpstan/phpstan": "^1.8",
         "phpunit/phpunit": "^8.5 || ^9.5",
         "squizlabs/php_codesniffer": "^3.0"
     },

config/services.xml

@@ -9,6 +9,7 @@
         <prototype namespace="Magento\CloudDocker\" resource="../src/*" exclude="../src/{Test}"/>
         <service id="Magento\CloudDocker\App\Container" autowire="false"/>
         <service id="Magento\CloudDocker\App\ContainerInterface" alias="container"/>
+        <service id="Psr\Container\ContainerInterface" alias="container"/>
         <service id="Magento\CloudDocker\App\ContainerException" autowire="false"/>
         <service id="Magento\CloudDocker\Compose\BuilderFactory">
             <argument key="$strategies" type="collection">

src/Compose/ProductionBuilder/Service/ElasticSearch.php

@@ -73,7 +73,7 @@ public function getConfig(Config $config): array
         return $this->serviceFactory->create(
             $this->getServiceName(),
             $config->getServiceVersion($this->getServiceName()),
-            !empty($esEnvVars) ? ['environment' => $esEnvVars] : [],
+            ['environment' => $esEnvVars],
             $config->getServiceImage($this->getServiceName()),
             $config->getCustomRegistry(),
             $config->getServiceImagePattern($this->getServiceName())

src/Compose/ProductionBuilder/Service/OpenSearch.php

@@ -84,7 +84,7 @@ public function getConfig(Config $config): array
         return $this->serviceFactory->create(
             $this->getServiceName(),
             $this->getVersion($config),
-            !empty($osEnvVars) ? ['environment' => $osEnvVars] : [],
+            ['environment' => $osEnvVars],
             $config->getServiceImage($this->getServiceName()),
             $config->getCustomRegistry(),
             $config->getServiceImagePattern($this->getServiceName())

tests/static/phpstan.neon

@@ -2,7 +2,7 @@ parameters:
     level: 5
     paths:
         - ../../src
-    excludes_analyse:
+    excludePaths:
         - ../../src/Test/*
     reportUnmatchedIgnoredErrors: false
     ignoreErrors: