Skip to content

Commit 6a55449

Browse files
authored
Merge pull request #292 from machinekoder/execute-preview
PathViewCore: execute preview for anything
2 parents cbe2fe3 + e0f49bd commit 6a55449

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

src/application/ApplicationCore.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,8 @@ Item {
167167
ready: fileService.ready
168168

169169
onUploadFinished: {
170-
fileSyncHandler.ignoreNextChange = true;
170+
var extension = remoteFilePath.split('.').pop();
171+
fileSyncHandler.ignoreNextChange = ["ngc", "txt"].indexOf(extension) != -1;
171172
executeProgram(remoteFilePath);
172173
}
173174
}

src/application/applicationfile.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ void ApplicationFile::startDownload()
162162

163163
if (!ready() || (m_transferState != NoTransfer))
164164
{
165+
qDebug() << "download failed" << ready() << m_transferState;
165166
return;
166167
}
167168

@@ -439,31 +440,34 @@ void ApplicationFile::ftpCommandFinished(int, bool error)
439440
{
440441
case QFtp::Get:
441442
cleanupFile();
442-
emit downloadFinished();
443443
updateState(NoTransfer);
444+
emit downloadFinished();
444445
return;
445446
case QFtp::List:
446-
emit refreshFinished();
447447
updateState(NoTransfer);
448+
emit refreshFinished();
448449
return;
449450
case QFtp::Put:
450451
cleanupFile();
452+
updateState(NoTransfer);
451453
emit uploadFinished();
452-
break;
454+
return;
453455
case QFtp::Remove:
456+
updateState(NoTransfer);
454457
emit removeFinished();
455458
break;
456459
case QFtp::Rmdir:
460+
updateState(NoTransfer);
457461
emit removeDirectoryFinished();
458462
break;
459463
case QFtp::Mkdir:
464+
updateState(NoTransfer);
460465
emit createDirectoryFinished();
461466
break;
462467
default:
463468
return;
464469
}
465470

466-
updateState(NoTransfer);
467471
refreshFiles();
468472
}
469473
} // namespace qtquickvcp

src/applicationcontrols/ApplicationFileDialog.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ FileDialog {
3838

3939
nameFilters: {
4040
var filters = []
41-
var allExtensions = ["*.ngc"]
41+
var allExtensions = ["*.ngc *.txt"]
4242

4343
if ((status.synced) && (status.config.programExtension !== undefined))
4444
{
@@ -63,6 +63,7 @@ FileDialog {
6363

6464
filters.unshift(qsTr("All machinable files (%1)").arg(allExtensions.join(" ")));
6565
filters.push(qsTr("rs274ngc files (*.ngc)"));
66+
filters.push(qsTr("Text files (*.txt)"));
6667
filters.push(qsTr("All files (*)"));
6768
return filters;
6869
}

src/pathview/PathViewCore.qml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,9 @@ ApplicationItem {
112112
}
113113

114114
function executePreview() {
115-
if (file.remoteFilePath.split('.').pop() === 'ngc') { // only open ngc files
116-
gcodeProgramModel.clearPreview();
117-
command.openProgram('preview', file.remoteFilePath);
118-
command.runProgram('preview', 0);
119-
}
115+
gcodeProgramModel.clearPreview();
116+
command.openProgram('preview', file.remoteFilePath);
117+
command.runProgram('preview', 0);
120118
}
121119
}
122120

0 commit comments

Comments
 (0)