fix: execute command before matching snapshot

Author: maartenpaauw

src/Commands/MakeSpecificationCommand.php

@@ -18,10 +18,10 @@ class MakeSpecificationCommand extends GeneratorCommand
     protected function getStub(): string
     {
         if ($this->option('composite')) {
-            return __DIR__ . '/../../stubs/specification-composite.stub';
+            return $this->resolveStubPath('/stubs/specification-composite.stub');
         }
 
-        return __DIR__ . '/../../stubs/specification.stub';
+        return $this->resolveStubPath('/stubs/specification.stub');
     }
 
     protected function getDefaultNamespace($rootNamespace): string
@@ -64,4 +64,12 @@ protected function getOptions(): array
             $candidate,
         ];
     }
+
+    protected function resolveStubPath(string $stub): string
+    {
+        $custom = $this->laravel->basePath(trim($stub, '/'));
+        $default = __DIR__ . $stub;
+
+        return file_exists($custom) ? $custom : $default;
+    }
 }

stubs/specification-composite.stub renamed to src/Commands/stubs/specification-composite.stub

@@ -8,7 +8,6 @@
 use Maartenpaauw\Specifications\Commands\MakeSpecificationCommand;
 use Maartenpaauw\Specifications\Tests\TestCase;
 use Spatie\Snapshots\MatchesSnapshots;
-use Symfony\Component\Console\Command\Command;
 
 class MakeSpecificationCommandTest extends TestCase
 {
@@ -17,51 +16,66 @@ class MakeSpecificationCommandTest extends TestCase
     /** @test */
     public function it_should_be_possible_to_create_a_basic_specification_class(): void
     {
-        // Act
+        // Arrange
         /** @var PendingCommand $command */
         $command = $this->artisan(MakeSpecificationCommand::class, [
             'name' => 'MyBasicSpecification',
         ]);
 
         // Assert
-        $command->assertExitCode(Command::SUCCESS);
+        $command->assertSuccessful();
+
+        // Act
+        $command->execute();
+
+        // Assert
         $this->assertSpecificationMatchesSnapshot('MyBasicSpecification');
     }
 
     /** @test */
     public function it_should_be_possible_to_create_a_composite_specification_class(): void
     {
-        // Act
+        // Arrange
         /** @var PendingCommand $command */
         $command = $this->artisan(MakeSpecificationCommand::class, [
             'name' => 'MyCompositeSpecification',
             '--composite' => true,
         ]);
 
         // Assert
-        $command->assertExitCode(Command::SUCCESS);
+        $command->assertSuccessful();
+
+        // Act
+        $command->execute();
+
+        // Assert
         $this->assertSpecificationMatchesSnapshot('MyCompositeSpecification');
     }
 
     /** @test */
     public function it_should_be_possible_to_create_a_basic_specification_with_a_candidate_type(): void
     {
-        // Act
+        // Arrange
         /** @var PendingCommand $command */
         $command = $this->artisan(MakeSpecificationCommand::class, [
             'name' => 'MyStrictBasicSpecification',
             '--candidate' => 'string',
         ]);
 
         // Assert
-        $command->assertExitCode(Command::SUCCESS);
+        $command->assertSuccessful();
+
+        // Act
+        $command->execute();
+
+        // Assert
         $this->assertSpecificationMatchesSnapshot('MyStrictBasicSpecification');
     }
 
     /** @test */
     public function it_should_be_possible_to_create_a_composite_specification_with_a_candidate_type(): void
     {
-        // Act
+        // Arrange
         /** @var PendingCommand $command */
         $command = $this->artisan(MakeSpecificationCommand::class, [
             'name' => 'MyStrictCompositeSpecification',
@@ -70,7 +84,12 @@ public function it_should_be_possible_to_create_a_composite_specification_with_a
         ]);
 
         // Assert
-        $command->assertExitCode(Command::SUCCESS);
+        $command->assertSuccessful();
+
+        // Act
+        $command->execute();
+
+        // Assert
         $this->assertSpecificationMatchesSnapshot('MyStrictCompositeSpecification');
     }