Merge branch 'master' of https://github.com/m0ver/tinystruct2.0.git

Author: m0ver

WEB-INF/lib/struct-2.0.jar

@@ -14,6 +14,7 @@
 import java.util.Date;
 import java.util.List;
 import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.ConcurrentLinkedQueue;
 
 import javax.servlet.ServletException;
@@ -61,31 +62,23 @@ public talk index() {
     }
 
     List<String> session_ids;
-    synchronized (this.meetings) {
-      final String sessionId = request.getSession().getId();
-      if (this.meetings.get(meetingCode) == null) {
-        this.meetings.put(meetingCode.toString(), new ConcurrentLinkedQueue<Builder>());
-      }
-
-      // If the current user is not in the list of the sessions, we create a default session list for the meeting generated.
-      if((session_ids = this.sessions.get(meetingCode)) == null)
-      {
-        this.sessions.put(meetingCode.toString(), session_ids = new ArrayList<String>());
-      }
-
-      if(!session_ids.contains(sessionId))
-      session_ids.add(sessionId);
+    final String sessionId = request.getSession().getId();
+    if (this.meetings.get(meetingCode) == null) {
+      this.meetings.put(meetingCode.toString(), new ArrayBlockingQueue<Builder>(DEFAULT_MESSAGE_POOL_SIZE));
+    }
 
-      this.meetings.notifyAll();
+    // If the current user is not in the list of the sessions, we create a default session list for the meeting generated.
+    if((session_ids = this.sessions.get(meetingCode)) == null)
+    {
+      this.sessions.put(meetingCode.toString(), session_ids = new ArrayList<String>());
     }
+
+    if(!session_ids.contains(sessionId))
+    session_ids.add(sessionId);
 
-    synchronized (this.list) {
-      final String sessionId = request.getSession().getId();
-      if(!this.list.containsKey(sessionId))
-      {
-        this.list.put(sessionId, new ConcurrentLinkedQueue<Builder>());
-      }
-      this.list.notifyAll();
+    if(!this.list.containsKey(sessionId))
+    {
+      this.list.put(sessionId, new ConcurrentLinkedQueue<Builder>());
     }
 
     this.setVariable("meeting_code", meetingCode.toString());
@@ -308,13 +301,10 @@ public void sessionCreated(HttpSessionEvent arg0) {
       System.out.println("New meeting generated by HttpSessionListener:" + meetingCode);
     }
 
-    synchronized (this.list) {
-      final String sessionId = arg0.getSession().getId();
-      if(!this.list.containsKey(sessionId))
-      {
-        this.list.put(sessionId, new ConcurrentLinkedQueue<Builder>());
-      }
-      this.list.notifyAll();
+    final String sessionId = arg0.getSession().getId();
+    if(!this.list.containsKey(sessionId))
+    {
+      this.list.put(sessionId, new ConcurrentLinkedQueue<Builder>());
     }
   }
 
@@ -331,25 +321,18 @@ public void sessionDestroyed(HttpSessionEvent arg0) {
 
       Queue<Builder> messages;
       List<String> session_ids;
-      synchronized (this.meetings) {
-        if((session_ids = this.sessions.get(meetingCode)) != null) {
-          session_ids.remove(arg0.getSession().getId());
-        }
-
-        if ((messages = this.meetings.get(meetingCode)) != null) {
-          messages.remove(meetingCode);
-        }
+      if((session_ids = this.sessions.get(meetingCode)) != null) {
+        session_ids.remove(arg0.getSession().getId());
+      }
 
-        this.meetings.notifyAll();
+      if ((messages = this.meetings.get(meetingCode)) != null) {
+        messages.remove(meetingCode);
       }
 
-      synchronized (this.list) {
-        final String sessionId = arg0.getSession().getId();
-        if(this.list.containsKey(sessionId))
-        {
-          this.list.remove(sessionId);
-        }
-        this.list.notifyAll();
+      final String sessionId = arg0.getSession().getId();
+      if(this.list.containsKey(sessionId))
+      {
+        this.list.remove(sessionId);
       }
     }
   }

src/tinystruct/examples/smalltalk.java

@@ -10,6 +10,8 @@
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.ExecutorService;
@@ -23,10 +25,11 @@
 
 public class talk extends AbstractApplication {
 
-  private static final long TIMEOUT = 200;
+  private static final long TIMEOUT = 10;
   private static final int DEFAULT_POOL_SIZE = 3;
+  protected static final int DEFAULT_MESSAGE_POOL_SIZE = 10;
+  protected final Map<String, BlockingQueue<Builder>> meetings = new ConcurrentHashMap<String, BlockingQueue<Builder>>();
   protected final Map<String, Queue<Builder>> list = new ConcurrentHashMap<String, Queue<Builder>>();
-  protected final Map<String, Queue<Builder>> meetings = new ConcurrentHashMap<String, Queue<Builder>>();
   protected final Map<String, List<String>> sessions = new ConcurrentHashMap<String, List<String>>();
   private ExecutorService service;
 
@@ -89,39 +92,30 @@ public String save(Object meetingCode, String sessionId, String message) {
    * @return builder
    */
   public final String save(final Object meetingCode, final Builder builder) {
-    final Queue<Builder> messages;
-    synchronized (this.meetings) {
-      if (this.meetings.get(meetingCode) == null) {
-        this.meetings.put(meetingCode.toString(), new ConcurrentLinkedQueue<Builder>());
-      }
+    BlockingQueue<Builder> messages;
+    if ((messages = this.meetings.get(meetingCode)) == null) {
+      this.meetings.put(meetingCode.toString(), messages = new ArrayBlockingQueue<Builder>(DEFAULT_MESSAGE_POOL_SIZE));
+    }
 
-      messages = this.meetings.get(meetingCode);
-      messages.add(builder);
-      this.meetings.notifyAll();
+    try {
+      messages.put(builder);
+    } catch (InterruptedException e) {
+      e.printStackTrace();
     }
 
     this.getService().execute(new Runnable(){
       @Override
       public void run() {
-        synchronized(talk.this.meetings) {
           Builder message;
-          do {
-            try {
-              talk.this.meetings.wait(TIMEOUT);
-            } catch (InterruptedException e) {
-                e.printStackTrace();
-            }
-          } while(talk.this.meetings.get(meetingCode) == null || (message = talk.this.meetings.get(meetingCode).poll()) == null);
-          
+          if (talk.this.meetings.get(meetingCode) == null || (message = talk.this.meetings.get(meetingCode).poll()) == null) return;
           talk.this.copy(meetingCode, message);
-        }
       }
     });
     return builder.toString();
   }
 
   private ExecutorService getService() {
-	return this.service!=null? this.service : Executors.newFixedThreadPool(DEFAULT_POOL_SIZE);
+    return this.service!=null? this.service : Executors.newFixedThreadPool(DEFAULT_POOL_SIZE);
   }
 
   /**
@@ -133,19 +127,16 @@ private ExecutorService getService() {
    */
   public final String update(final String sessionId) throws ApplicationException, IOException {
     Builder message;
-    Queue<Builder> messages;
-    synchronized (this.list) {
-      messages = this.list.get(sessionId);
-      while((message = messages.poll()) == null) {
-        try {
-          this.list.wait(TIMEOUT);
-        } catch (InterruptedException e) {
-          throw new ApplicationException(e.getMessage(), e);
-        }
+    Queue<Builder> messages = this.list.get(sessionId);
+    while((message = messages.poll()) == null) {
+      try {
+        Thread.sleep(TIMEOUT);
+      } catch (InterruptedException e) {
+        throw new ApplicationException(e.getMessage(), e);
       }
-
-      return message.toString();
     }
+
+    return message.toString();
   }
 
   /**
@@ -163,22 +154,17 @@ protected String filter(String text) {
    * @param builder
    */
   private final void copy(Object meetingCode, Builder builder) {
-    synchronized(this.list) {
-      final Collection<Entry<String, Queue<Builder>>> set = list.entrySet();
+      final Collection<Entry<String, Queue<Builder>>> set = this.list.entrySet();
       final Iterator<Entry<String, Queue<Builder>>> iterator = set.iterator();
-      final List<String> meeting_session;
-      if((meeting_session = this.sessions.get(meetingCode)) != null) {
+      final List<String> _sessions;
+      if((_sessions = this.sessions.get(meetingCode)) != null) {
         while(iterator.hasNext()) {
-          Entry<String, Queue<Builder>> e = iterator.next();
-          if(meeting_session.contains(e.getKey())) {
-            e.getValue().add(builder);
-            this.list.notifyAll();
+          Entry<String, Queue<Builder>> list = iterator.next();
+          if(_sessions.contains(list.getKey())) {
+	            list.getValue().add(builder);
           }
         }
       }
-      else
-      this.list.notifyAll();
-    }
   }
 
   @Override
@@ -195,7 +181,7 @@ public String version() {
    * @throws ApplicationException
    */
   public boolean testing(final int n) throws ApplicationException {
-    this.meetings.put("[M001]", new ConcurrentLinkedQueue<Builder>());
+    this.meetings.put("[M001]", new ArrayBlockingQueue<Builder>(DEFAULT_MESSAGE_POOL_SIZE));
     this.list.put("{A}", new ConcurrentLinkedQueue<Builder>());
     this.list.put("{B}", new ConcurrentLinkedQueue<Builder>());