Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Commit f61c610

Browse files
authored
Corrections based on feedback by Leonor (#95)
- Fix typo in type name reported by @LeonorLunatech
1 parent 657eb5c commit f61c610

File tree

42 files changed

+104
-104
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+104
-104
lines changed

exercises/exercise_000_sudoku_solver_initial_state/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ object SudokuDetailProcessor {
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
23+
def apply[DetailType <: SudokuDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2424
implicit updateSender: UpdateSender[DetailType]
2525
): Behavior[Command] =
2626
Behaviors.setup { context =>
@@ -51,7 +51,7 @@ object SudokuDetailProcessor {
5151
}
5252
}
5353

54-
class SudokuDetailProcessor[DetailType <: SudokoDetailType: UpdateSender] private (
54+
class SudokuDetailProcessor[DetailType <: SudokuDetailType: UpdateSender] private(
5555
context: ActorContext[SudokuDetailProcessor.Command]
5656
) {
5757

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.lunatechlabs.dotty.sudoku
22

3-
sealed trait SudokoDetailType
4-
case class Row(id: Int) extends SudokoDetailType
5-
case class Column(id: Int) extends SudokoDetailType
6-
case class Block(id: Int) extends SudokoDetailType
3+
sealed trait SudokuDetailType
4+
case class Row(id: Int) extends SudokuDetailType
5+
case class Column(id: Int) extends SudokuDetailType
6+
case class Block(id: Int) extends SudokuDetailType

exercises/exercise_000_sudoku_solver_initial_state/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuSolver.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ object SudokuSolver {
2626

2727
import SudokuDetailProcessor.UpdateSender
2828

29-
def genDetailProcessors[A <: SudokoDetailType: UpdateSender](
29+
def genDetailProcessors[A <: SudokuDetailType: UpdateSender](
3030
context: ActorContext[Command]
3131
): Map[Int, ActorRef[SudokuDetailProcessor.Command]] = {
3232
cellIndexesVector

exercises/exercise_001_dotty_deprecated_syntax_rewriting/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ object SudokuDetailProcessor {
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
23+
def apply[DetailType <: SudokuDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2424
implicit updateSender: UpdateSender[DetailType]
2525
): Behavior[Command] =
2626
Behaviors.setup { context =>
@@ -51,7 +51,7 @@ object SudokuDetailProcessor {
5151
}
5252
}
5353

54-
class SudokuDetailProcessor[DetailType <: SudokoDetailType: UpdateSender] private (
54+
class SudokuDetailProcessor[DetailType <: SudokuDetailType: UpdateSender] private(
5555
context: ActorContext[SudokuDetailProcessor.Command]
5656
) {
5757

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.lunatechlabs.dotty.sudoku
22

3-
sealed trait SudokoDetailType
4-
case class Row(id: Int) extends SudokoDetailType
5-
case class Column(id: Int) extends SudokoDetailType
6-
case class Block(id: Int) extends SudokoDetailType
3+
sealed trait SudokuDetailType
4+
case class Row(id: Int) extends SudokuDetailType
5+
case class Column(id: Int) extends SudokuDetailType
6+
case class Block(id: Int) extends SudokuDetailType

exercises/exercise_001_dotty_deprecated_syntax_rewriting/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuSolver.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ object SudokuSolver {
2626

2727
import SudokuDetailProcessor.UpdateSender
2828

29-
def genDetailProcessors[A <: SudokoDetailType: UpdateSender](
29+
def genDetailProcessors[A <: SudokuDetailType: UpdateSender](
3030
context: ActorContext[Command]
3131
): Map[Int, ActorRef[SudokuDetailProcessor.Command]] = {
3232
cellIndexesVector

exercises/exercise_002_dotty_new_syntax_and_indentation_based_syntax/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ object SudokuDetailProcessor:
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
23+
def apply[DetailType <: SudokuDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2424
implicit updateSender: UpdateSender[DetailType]
2525
): Behavior[Command] =
2626
Behaviors.setup { context =>
@@ -46,7 +46,7 @@ object SudokuDetailProcessor:
4646
sender ! BlockUpdate(id, cellUpdates)
4747
def processorName(id: Int): String = s"blk-processor-$id"
4848

49-
class SudokuDetailProcessor[DetailType <: SudokoDetailType: UpdateSender] private (
49+
class SudokuDetailProcessor[DetailType <: SudokuDetailType: UpdateSender] private(
5050
context: ActorContext[SudokuDetailProcessor.Command]
5151
):
5252

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.lunatechlabs.dotty.sudoku
22

3-
sealed trait SudokoDetailType
4-
case class Row(id: Int) extends SudokoDetailType
5-
case class Column(id: Int) extends SudokoDetailType
6-
case class Block(id: Int) extends SudokoDetailType
3+
sealed trait SudokuDetailType
4+
case class Row(id: Int) extends SudokuDetailType
5+
case class Column(id: Int) extends SudokuDetailType
6+
case class Block(id: Int) extends SudokuDetailType

exercises/exercise_002_dotty_new_syntax_and_indentation_based_syntax/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuSolver.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ object SudokuSolver:
2626

2727
import SudokuDetailProcessor.UpdateSender
2828

29-
def genDetailProcessors[A <: SudokoDetailType: UpdateSender](
29+
def genDetailProcessors[A <: SudokuDetailType: UpdateSender](
3030
context: ActorContext[Command]
3131
): Map[Int, ActorRef[SudokuDetailProcessor.Command]] =
3232
cellIndexesVector

exercises/exercise_003_top_level_definitions/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ object SudokuDetailProcessor:
1919
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2020
case object SudokuDetailUnchanged extends Response
2121

22-
def apply[DetailType <: SudokoDetailType](id: Int,
23-
state: ReductionSet = InitialDetailState)
24-
(implicit updateSender: UpdateSender[DetailType]): Behavior[Command] =
22+
def apply[DetailType <: SudokuDetailType](id: Int, state: ReductionSet = InitialDetailState)(
23+
implicit updateSender: UpdateSender[DetailType]
24+
): Behavior[Command] =
2525
Behaviors.setup { context =>
2626
(new SudokuDetailProcessor[DetailType](context)).operational(id, state, fullyReduced = false)
2727
}
@@ -48,7 +48,7 @@ object SudokuDetailProcessor:
4848
def processorName(id: Int): String = s"blk-processor-$id"
4949
}
5050

51-
class SudokuDetailProcessor[DetailType <: SudokoDetailType : UpdateSender] private (context: ActorContext[SudokuDetailProcessor.Command]):
51+
class SudokuDetailProcessor[DetailType <: SudokuDetailType: UpdateSender] private(context: ActorContext[SudokuDetailProcessor.Command]):
5252

5353
import ReductionRules.{reductionRuleOne, reductionRuleTwo}
5454
import SudokuDetailProcessor.*

0 commit comments

Comments
 (0)