Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Commit a10c1fa

Browse files
authored
Refactor code in prep for opaque type aliases exercise (#84)
- Move definition of field to package/top-level definition
1 parent d82b5c9 commit a10c1fa

File tree

24 files changed

+12
-24
lines changed

24 files changed

+12
-24
lines changed

exercises/exercise_000_sudoku_solver_initial_state/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ object SudokuDetailProcessor {
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
24-
2523
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2624
implicit updateSender: UpdateSender[DetailType]
2725
): Behavior[Command] =

exercises/exercise_000_sudoku_solver_initial_state/src/main/scala/org/lunatechlabs/dotty/sudoku/package.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package object sudoku {
66
val CELLPossibleValues: Vector[Int] = (1 to N).toVector
77
val cellIndexesVector: Vector[Int] = Vector.range(0, N)
88
val initialCell: Set[Int] = Set.range(1, 10)
9+
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
910

1011
type CellContent = Set[Int]
1112
type ReductionSet = Vector[CellContent]

exercises/exercise_001_dotty_deprecated_syntax_rewriting/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ object SudokuDetailProcessor {
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
24-
2523
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2624
implicit updateSender: UpdateSender[DetailType]
2725
): Behavior[Command] =

exercises/exercise_001_dotty_deprecated_syntax_rewriting/src/main/scala/org/lunatechlabs/dotty/sudoku/package.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package object sudoku {
66
val CELLPossibleValues: Vector[Int] = (1 to N).toVector
77
val cellIndexesVector: Vector[Int] = Vector.range(0, N)
88
val initialCell: Set[Int] = Set.range(1, 10)
9+
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
910

1011
type CellContent = Set[Int]
1112
type ReductionSet = Vector[CellContent]

exercises/exercise_002_dotty_new_syntax_and_indentation_based_syntax/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ object SudokuDetailProcessor:
2020
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2121
case object SudokuDetailUnchanged extends Response
2222

23-
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
24-
2523
def apply[DetailType <: SudokoDetailType](id: Int, state: ReductionSet = InitialDetailState)(
2624
implicit updateSender: UpdateSender[DetailType]
2725
): Behavior[Command] =

exercises/exercise_002_dotty_new_syntax_and_indentation_based_syntax/src/main/scala/org/lunatechlabs/dotty/sudoku/package.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package object sudoku:
66
val CELLPossibleValues: Vector[Int] = (1 to N).toVector
77
val cellIndexesVector: Vector[Int] = Vector.range(0, N)
88
val initialCell: Set[Int] = Set.range(1, 10)
9+
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
910

1011
type CellContent = Set[Int]
1112
type ReductionSet = Vector[CellContent]

exercises/exercise_003_top_level_definitions/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ object SudokuDetailProcessor:
1919
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2020
case object SudokuDetailUnchanged extends Response
2121

22-
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
23-
2422
def apply[DetailType <: SudokoDetailType](id: Int,
2523
state: ReductionSet = InitialDetailState)
2624
(implicit updateSender: UpdateSender[DetailType]): Behavior[Command] =

exercises/exercise_003_top_level_definitions/src/main/scala/org/lunatechlabs/dotty/sudoku/TopLevelDefinitions.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ private val N = 9
44
val CELLPossibleValues: Vector[Int] = (1 to N).toVector
55
val cellIndexesVector: Vector[Int] = Vector.range(0, N)
66
val initialCell: Set[Int] = Set.range(1, 10)
7+
val InitialDetailState = cellIndexesVector.map(_ => initialCell)
78

89
type CellContent = Set[Int]
910
type ReductionSet = Vector[CellContent]

exercises/exercise_004_parameter_untupling/src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuDetailProcessor.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ object SudokuDetailProcessor:
1919
final case class BlockUpdate(id: Int, cellUpdates: CellUpdates) extends Response
2020
case object SudokuDetailUnchanged extends Response
2121

22-
val InitialDetailState: ReductionSet = cellIndexesVector.map(_ => initialCell)
23-
2422
def apply[DetailType <: SudokoDetailType](id: Int,
2523
state: ReductionSet = InitialDetailState)
2624
(implicit updateSender: UpdateSender[DetailType]): Behavior[Command] =

exercises/exercise_004_parameter_untupling/src/main/scala/org/lunatechlabs/dotty/sudoku/TopLevelDefinitions.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ private val N = 9
44
val CELLPossibleValues: Vector[Int] = (1 to N).toVector
55
val cellIndexesVector: Vector[Int] = Vector.range(0, N)
66
val initialCell: Set[Int] = Set.range(1, 10)
7+
val InitialDetailState = cellIndexesVector.map(_ => initialCell)
78

89
type CellContent = Set[Int]
910
type ReductionSet = Vector[CellContent]

0 commit comments

Comments
 (0)