Skip to content

[BUG] Dispose of file stream in AttachFromFilename #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BUG] Dispose of file stream in AttachFromFilename #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a59b4
Dispose of file stream in AttachFromFilename
asherber Mar 29, 2024
6531720
Use MemoryStream, which doesn't need to be disposed
asherber Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FluentEmail.Core/Email.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ public IFluentEmail Attach(IEnumerable<Attachment> attachments)

public IFluentEmail AttachFromFilename(string filename, string contentType = null, string attachmentName = null)
{
var stream = File.OpenRead(filename);
var stream = new MemoryStream(File.ReadAllBytes(filename));
Attach(new Attachment
{
Data = stream,
Expand Down