Inline a function that is only used once

Author: oli-obk

compiler/rustc_errors/src/lib.rs

@@ -553,37 +553,21 @@ impl Handler {
         sm: Option<Lrc<SourceMap>>,
         fallback_bundle: LazyFallbackBundle,
     ) -> Self {
-        Self::with_tty_emitter_and_flags(
+        let flags =
+            HandlerFlags { can_emit_warnings, treat_err_as_bug: None, ..Default::default() };
+        let emitter = Box::new(EmitterWriter::stderr(
             ColorConfig::Auto,
             sm,
             None,
             fallback_bundle,
-            HandlerFlags { can_emit_warnings, treat_err_as_bug: None, ..Default::default() },
-            None,
-        )
-    }
-
-    pub fn with_tty_emitter_and_flags(
-        color_config: ColorConfig,
-        sm: Option<Lrc<SourceMap>>,
-        fluent_bundle: Option<Lrc<FluentBundle>>,
-        fallback_bundle: LazyFallbackBundle,
-        flags: HandlerFlags,
-        ice_file: Option<PathBuf>,
-    ) -> Self {
-        let emitter = Box::new(EmitterWriter::stderr(
-            color_config,
-            sm,
-            fluent_bundle,
-            fallback_bundle,
             false,
             false,
             None,
             flags.macro_backtrace,
             flags.track_diagnostics,
             TerminalUrl::No,
         ));
-        Self::with_emitter_and_flags(emitter, flags, ice_file)
+        Self::with_emitter_and_flags(emitter, flags, None)
     }
 
     pub fn with_emitter(