ci(deploy): Fix deploy output

Author: lucasssvaz

.github/workflows/cron.yml

@@ -21,7 +21,7 @@ defaults:
 jobs:
   build-libs:
     name: Build with IDF ${{ matrix.idf_branch }}
-    if: github.repository_owner == 'espressif'
+    if: github.repository_owner == 'espressif' || github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/cron_build.yml
     with:
       idf_branch: ${{ matrix.idf_branch }}

.github/workflows/cron_build.yml

@@ -51,7 +51,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          source ./tools/check-deploy-needed.sh
+          bash ./tools/check-deploy-needed.sh
           targets_list=$(echo "${{ inputs.targets }}" | sed 's/ *, */,/g' | sed 's/^/["/' | sed 's/$/"]/' | sed 's/,/","/g')
           echo "Targets list: $targets_list"
           echo "targets_list=$targets_list" >> $GITHUB_OUTPUT

tools/check-deploy-needed.sh

@@ -119,7 +119,7 @@ echo "LIBS_ASSET_ID: $LIBS_ASSET_ID"
 echo "LIBS_HAS_ASSET: $LIBS_HAS_ASSET"
 echo "DEPLOY_NEEDED: $DEPLOY_NEEDED"
 
-if [ ! -x $GITHUB_OUTPUT ]; then
+if [ -n "$GITHUB_OUTPUT" ]; then
 	echo "idf_commit=$IDF_COMMIT" >> "$GITHUB_OUTPUT"
 	echo "ar_branch=$AR_BRANCH" >> "$GITHUB_OUTPUT"
 	echo "ar_new_commit_message=$AR_NEW_COMMIT_MESSAGE" >> "$GITHUB_OUTPUT"

tools/config.sh

@@ -175,29 +175,35 @@ function github_pr_exists(){ # github_pr_exists <repo-path> <branch-name>
     if [ ! "$pr_num" == "" ] && [ ! "$pr_num" == "null" ]; then echo 1; else echo 0; fi
 }
 
-function github_release_id(){ # github_release_id <repo-path> <release-tag>
+function github_release_id() { # github_release_id <repo-path> <release-tag>
     local repo_path="$1"
     local release_tag="$2"
     local page=1
     local release_id=""
 
     while [[ "$page" -le 3 ]]; do
-        local response=`curl -s -k -H "Authorization: token $GITHUB_TOKEN" -H "Accept: application/vnd.github.v3.raw+json" "https://api.github.com/repos/$repo_path/releases?per_page=100&page=$page"`
-
-        if [[ -z "$response" || "$response" == "[]" ]]; then
-            break
-        fi
-
-        local release=`echo "$response" | jq --arg release_tag "$release_tag" -r '.[] | select(.tag_name == $release_tag) | .id'`
-        if [ ! "$release" == "" ] && [ ! "$release" == "null" ]; then
-            release_id=$release
-            break
+        local response
+        response=$(curl -sf -H "Authorization: token $GITHUB_TOKEN" \
+                          -H "Accept: application/vnd.github.v3.raw+json" \
+                          "https://api.github.com/repos/$repo_path/releases?per_page=100&page=$page") || {
+            echo "Failed to fetch releases from GitHub for $repo_path" >&2
+            exit 1
+        }
+
+        # stop if empty or no releases
+        [[ -z "$response" || "$response" == "[]" ]] && break
+
+        release_id=$(echo "$response" | jq --arg tag "$release_tag" -r '.[] | select(.tag_name == $tag) | .id')
+        if [[ -n "$release_id" && "$release_id" != "null" ]]; then
+            echo "$release_id"
+            return 0
         fi
 
         page=$((page+1))
     done
 
-    echo "$release_id"
+    echo "Release '$release_tag' not found in $repo_path" >&2
+    exit 1
 }
 
 function github_release_asset_id(){ # github_release_asset_id <repo-path> <release-id> <release-file>