Skip to content

Commit b9f0d56

Browse files
committed
Fix some lists used as default parameters
1 parent 2f168c5 commit b9f0d56

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

python/lsst/sconsUtils/dependencies.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,9 @@ class Configuration:
167167
name ``<root>/doc/<name>.inc``.
168168
hasDoxygenTag : `bool`, optional
169169
If True, the package generates a Doxygen TAG file.
170-
includeFileDirs : `list`, optional
170+
includeFileDirs : `collections.abc.Sequence`, optional
171171
List of directories that should be searched for include files.
172-
libFileDirs : `list`, optional
172+
libFileDirs : `collections.abs.Sequence`, optional
173173
List of directories that should be searched for libraries.
174174
eupsProduct : `str`
175175
Name of the EUPS product for the package, if different from the name
@@ -223,8 +223,8 @@ def __init__(
223223
headers=(),
224224
libs=None,
225225
hasSwigFiles=True,
226-
includeFileDirs=["include"],
227-
libFileDirs=["lib"],
226+
includeFileDirs=("include",),
227+
libFileDirs=("lib",),
228228
hasDoxygenInclude=False,
229229
hasDoxygenTag=True,
230230
eupsProduct=None,

python/lsst/sconsUtils/installation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def InstallDir(self, prefix, dir, ignoreRegex=r"(~$|\.pyc$|\.os?$)", recursive=T
359359

360360

361361
@memberOf(SConsEnvironment)
362-
def InstallEups(env, dest, files=[], presetup=""):
362+
def InstallEups(env, dest, files=(), presetup=""):
363363
"""Install a ups directory, setting absolute versions as appropriate
364364
(unless you're installing from the trunk, in which case no versions
365365
are expanded).
@@ -370,7 +370,7 @@ def InstallEups(env, dest, files=[], presetup=""):
370370
Environment to use.
371371
dest : `str`
372372
Destination directory.
373-
files : `list`, optional
373+
files : `collections.abc.Sequence`, optional
374374
List of files to install. Any build/table files present in ``./ups``
375375
are automatically added to this list.
376376
presetup : `dict`, optional

python/lsst/sconsUtils/scripts.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ def python(module=None, src=None, extra=(), libs="main python"):
455455
return result
456456

457457
@staticmethod
458-
def pybind11(nameList=[], libs="main python", extraSrc=None, addUnderscore=True):
458+
def pybind11(nameList=(), libs="main python", extraSrc=None, addUnderscore=True):
459459
"""Convenience function to replace standard ``python/*/SConscript``
460460
boilerplate.
461461
@@ -467,7 +467,7 @@ def pybind11(nameList=[], libs="main python", extraSrc=None, addUnderscore=True)
467467
468468
Parameters
469469
----------
470-
nameList : `list`, optional
470+
nameList : `collections.abc.Sequence`, optional
471471
Sequence of pybind11 modules to be built (does not include the
472472
file extensions).
473473
libs : `str` or `list`, optional

0 commit comments

Comments
 (0)