Merge pull request #626 from raheeliftikhar5/worflows-updates

Worflows updates + Table fixes

Author: FalkWolsky

.github/workflows/publish-lowcoder-cli.yml

@@ -9,6 +9,7 @@ on:
 
 jobs:
   publish-package:
+    if: ${{ github.repositoryUrl == 'git://github.com/lowcoder/lowcoder.git'}}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -19,7 +20,9 @@ jobs:
         id: check
         with:
           diff-search: true
+          static-checking: localIsNew
           file-name: client/packages/lowcoder-cli/package.json
+          file-url: https://unpkg.com/lowcoder-cli@latest/package.json
 
       - name: Version update detected
         if: steps.check.outputs.changed == 'true'

.github/workflows/publish-lowcoder-comps.yml

@@ -9,6 +9,7 @@ on:
 
 jobs:
   publish-package:
+    if: ${{ github.repositoryUrl == 'git://github.com/lowcoder/lowcoder.git'}}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -19,7 +20,9 @@ jobs:
         id: check
         with:
           diff-search: true
+          static-checking: localIsNew
           file-name: client/packages/lowcoder-comps/package.json
+          file-url: https://unpkg.com/lowcoder-comps@latest/package.json
 
       - name: Version update detected
         if: steps.check.outputs.changed == 'true'

.github/workflows/publish-lowcoder-core.yml

@@ -9,6 +9,7 @@ on:
 
 jobs:
   publish-package:
+    if: ${{ github.repositoryUrl == 'git://github.com/lowcoder/lowcoder.git'}}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -19,7 +20,9 @@ jobs:
         id: check
         with:
           diff-search: true
+          static-checking: localIsNew
           file-name: client/packages/lowcoder-core/package.json
+          file-url: https://unpkg.com/lowcoder-core@latest/package.json
 
       - name: Version update detected
         if: steps.check.outputs.changed == 'true'

.github/workflows/publish-lowcoder-sdk.yml

@@ -9,6 +9,7 @@ on:
 
 jobs:
   publish-package:
+    if: ${{ github.repositoryUrl == 'git://github.com/lowcoder/lowcoder.git'}}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -19,7 +20,9 @@ jobs:
         id: check
         with:
           diff-search: true
+          static-checking: localIsNew
           file-name: client/packages/lowcoder-sdk/package.json
+          file-url: https://unpkg.com/lowcoder-sdk@latest/package.json
 
       - name: Version update detected
         if: steps.check.outputs.changed == 'true'

client/packages/lowcoder/src/comps/comps/tableComp/column/tableColumnComp.tsx

@@ -27,7 +27,6 @@ import { ColorControl } from "comps/controls/colorControl";
 import { JSONValue } from "util/jsonTypes";
 import styled from "styled-components";
 import { TextOverflowControl } from "comps/controls/textOverflowControl";
-import { TableColumnLinkStyle, styleControl } from "@lowcoder-ee/index.sdk";
 import { default as Divider } from "antd/es/divider";
 export type Render = ReturnType<ConstructorToComp<typeof RenderComp>["getOriginalComp"]>;
 export const RenderComp = withSelectedMultiContext(ColumnTypeComp);
@@ -86,6 +85,7 @@ export type CellColorViewType = (param: {
 export const columnChildrenMap = {
   // column title
   title: StringControl,
+  showTitle: withDefault(BoolControl, true),
   // a custom column or a data column
   isCustom: valueComp<boolean>(false),
   // If it is a data column, it must be the name of the column and cannot be duplicated as a react key
@@ -149,6 +149,13 @@ export class ColumnComp extends ColumnInitComp {
         )
       );
     }
+    if(action.type === CompActionTypes.CHANGE_VALUE) {
+      const title = comp.children.title.unevaledValue;
+      const dataIndex = comp.children.dataIndex.getView();
+      if(!Boolean(title)) {
+        comp.children.title.dispatchChangeValueAction(dataIndex);
+      }
+    }
     return comp;
   }
 
@@ -180,9 +187,14 @@ export class ColumnComp extends ColumnInitComp {
       <>
         {this.children.title.propertyView({
           label: trans("table.columnTitle"),
+          placeholder: this.children.dataIndex.getView(),
         })}
         {/* FIXME: cast type currently, return type of withContext should be corrected later */}
         {this.children.render.getPropertyView()}
+        {this.children.showTitle.propertyView({
+          label: trans("table.showTitle"),
+          tooltip: trans("table.showTitleTooltip"),
+        })}
         {ColumnTypeCompMap[columnType].canBeEditable() &&
           this.children.editable.propertyView({ label: trans("table.editable") })}
         {this.children.sortable.propertyView({
@@ -311,6 +323,7 @@ export function newPrimaryColumn(
   title?: string,
   isTag?: boolean
 ): ConstructorToDataType<typeof ColumnComp> {
+  console.log('newPrimaryColumn', title);
   return {
     title: title ?? key,
     dataIndex: key,

client/packages/lowcoder/src/comps/comps/tableComp/column/tableColumnListComp.tsx

@@ -101,7 +101,6 @@ export class ColumnListComp extends ColumnListTmpComp {
     dynamicColumn: boolean;
     data: Array<JSONObject>;
   }) {
-    console.log("dataChangedAction", param);
     return customAction<ActionDataType>(
       {
         type: "dataChanged",

client/packages/lowcoder/src/comps/comps/tableComp/tableCompView.tsx

@@ -553,11 +553,6 @@ function ResizeableTable<RecordType extends object>(props: CustomTableProps<Reco
     } else {
       allColumnFixed = false;
     }
-    if (allColumnFixed && index === props.columns.length - 1) {
-      // all column fixed, the last column fill extra space
-      colWidth = "auto";
-      minWidth = resizeWidth;
-    }
     return {
       ...restCol,
       RC_TABLE_INTERNAL_COL_DEFINE: {
@@ -583,14 +578,6 @@ function ResizeableTable<RecordType extends object>(props: CustomTableProps<Reco
         width: resizeWidth,
         title: col.titleText,
         viewModeResizable: props.viewModeResizable,
-        // onResize: (width: number) => {
-        //   if (width) {
-        //     setResizeData({
-        //       index: index,
-        //       width: width,
-        //     });
-        //   }
-        // },
         onResize: (width: React.SyntheticEvent) => {
           if (width) {
             setResizeData({

client/packages/lowcoder/src/comps/comps/tableComp/tableToolbarComp.tsx

@@ -609,7 +609,7 @@ function ColumnSetting(props: {
       allChecked = false;
     }
     return (
-      <ColumnCheckItem>
+      <ColumnCheckItem key={columnView.dataIndex}>
         <CheckBox
           checked={checked}
           onChange={(e) => {
@@ -677,6 +677,7 @@ function ToolbarPopover(props: {
     <Popover
       open={visible}
       overlayStyle={{ pointerEvents: "auto" }}
+      overlayInnerStyle={{ padding: '0' }}
       content={
         <div
           ref={popOverRef}

client/packages/lowcoder/src/comps/comps/tableComp/tableUtils.tsx

@@ -311,7 +311,7 @@ export function columnsToAntdFormat(
     }[];
     const title = renderTitle({ title: column.title, editable: column.editable });
     return {
-      title: title,
+      title: column.showTitle ? title : '',
       titleText: column.title,
       dataIndex: column.dataIndex,
       align: column.align,

client/packages/lowcoder/src/i18n/locales/de.ts

@@ -1124,7 +1124,9 @@ export const de = {
       "columnValueTooltip": "\\'{{currentCell}}\\': Aktuelle Zelldaten\n \\'{{currentRow}}\\': Aktuelle Zeilendaten\n \\'{{currentIndex}}\\': Aktueller Datenindex (beginnend bei 0)\n Beispiel: \\'{{currentCell * 5}}\\' Show 5 Times the Original Value Data.",
       "imageSrc": "Bildquelle",
       "imageSize": "Bildgröße",
-      "columnTitle": "Titel",
+      "columnTitle": "Titel anzeigen",
+      "showTitle": "Show Title",
+      "showTitleTooltip": "Spaltentitel im Tabellenkopf ein-/ausblenden",
       "sortable": "Sortierbar",
       "align": "Ausrichtung",
       "fixedColumn": "Feste Säule",