Clean up warnings

Signed-off-by: Michael Lodder <redmike7@gmail.com>

Author: mikelodder7

src/constants.rs

@@ -8,7 +8,7 @@ pub const NLEN: usize = curve_NLEN;
 pub const BigNumBits: usize = BASEBITS;
 
 // Byte size of element in group G1, 1 extra byte for compression flag
-pub const GROUP_G1_SIZE: usize = (2 * MODBYTES + 1);
+pub const GROUP_G1_SIZE: usize = 2 * MODBYTES + 1;
 
 lazy_static! {
     pub static ref GENERATOR_G1: GroupG1 = GroupG1::generator();
@@ -37,4 +37,4 @@ lazy_static! {
 }
 
 #[cfg(any(feature = "bls381", feature = "bn254"))]
-pub use crate::types_g2::{GeneratorG2, GroupG2_SIZE, GroupGT_SIZE};
+pub use crate::types_g2::{GENERATOR_G2, GROUP_G2_SIZE, GROUP_GT_SIZE};

src/extension_field_gt.rs

@@ -10,11 +10,11 @@ use crate::group_elem_g2::{G2, parse_hex_as_FP2};
 use std::fmt;
 use std::hash::{Hash, Hasher};
 use crate::errors::SerzDeserzError;
-use crate::constants::GroupGT_SIZE;
+use crate::constants::GROUP_GT_SIZE;
 
 use serde::de::{Deserialize, Deserializer, Error as DError, Visitor};
-use serde::ser::{Error as SError, Serialize, Serializer};
-use std::str::{FromStr, SplitWhitespace};
+use serde::ser::{Serialize, Serializer};
+use std::str::SplitWhitespace;
 use zeroize::Zeroize;
 
 #[derive(Clone)]
@@ -29,13 +29,6 @@ impl fmt::Debug for GT {
     }
 }
 
-impl fmt::Debug for GT {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        let mut c = self.value.clone();
-        write!(f, "{}", c.tostring())
-    }
-}
-
 impl GT {
     pub fn new() -> Self {
         Self {
@@ -137,16 +130,16 @@ impl GT {
     pub fn to_bytes(&self) -> Vec<u8> {
         let mut temp = FP12::new();
         temp.copy(&self.value);
-        let mut bytes: [u8; GroupGT_SIZE] = [0; GroupGT_SIZE];
+        let mut bytes = [0u8; GROUP_GT_SIZE];
         temp.tobytes(&mut bytes);
         bytes.to_vec()
     }
 
     pub fn from_bytes(bytes: &[u8]) -> Result<Self, SerzDeserzError> {
-        if bytes.len() != GroupGT_SIZE {
+        if bytes.len() != GROUP_GT_SIZE {
             return Err(SerzDeserzError::GTBytesIncorrectSize(
                 bytes.len(),
-                GroupGT_SIZE,
+                GROUP_GT_SIZE,
             ));
         }
         Ok(Self {
@@ -200,7 +193,7 @@ impl PartialEq for GT {
     }
 }
 
-impl_group_elem_conversions!(GT, GroupGT, GroupGT_SIZE);
+impl_group_elem_conversions!(GT, GroupGT, GROUP_GT_SIZE);
 
 impl_group_elem_traits!(GT, GroupGT);
 

src/group_elem_g1.rs

@@ -12,7 +12,6 @@ use std::slice::Iter;
 
 use serde::de::{Deserialize, Deserializer, Error as DError, Visitor};
 use serde::ser::{Serialize, Serializer};
-use zeroize::Zeroize;
 use std::str::{FromStr, SplitWhitespace};
 use zeroize::Zeroize;
 

src/types_g2.rs

@@ -2,10 +2,10 @@ use crate::constants::MODBYTES;
 
 use super::types::GroupG2;
 // Byte size of element in group G2
-pub const GROUP_G2_SIZE: usize = (4 * MODBYTES);
+pub const GROUP_G2_SIZE: usize = 4 * MODBYTES;
 
 // Byte size of element in group GT
-pub const GroupGT_SIZE: usize = (12 * MODBYTES) as usize;
+pub const GROUP_GT_SIZE: usize = 12 * MODBYTES;
 
 lazy_static! {
     pub static ref GENERATOR_G2: GroupG2 = GroupG2::generator();

src/utils.rs

@@ -6,9 +6,8 @@ use rand::prelude::*;
 use crate::constants::{CURVE_ORDER, MODBYTES};
 use crate::types::{BigNum, DoubleBigNum};
 
-use crate::errors::SerzDeserzError;
 use sha3::digest::{ExtendableOutput, Input, XofReader};
-use sha3::{Digest, Sha3_256, Shake256};
+use sha3::Shake256;
 
 
 /// Generate a random number twice the number of bytes as the curve reduced by mod CURVE_ORDER