Properly handle command errors (e.g. OOM)

Author: nukemberg

lib/logstash/outputs/redis.rb

@@ -170,12 +170,12 @@ def receive(event)
       else
         @redis.publish(key, payload)
       end
-    rescue => e
-      @logger.warn("Failed to send event to Redis", :event => event,
-                   :identity => identity, :exception => e,
-                   :backtrace => e.backtrace)
+    rescue Redis::CommandError => e
+      @logger.warn("Redis write rejected: #{e.message}", :identity => identity)
       sleep @reconnect_interval
-      @redis = nil
+      retry
+    rescue => e
+      on_send_error(e)
       retry
     end
   end # def receive
@@ -200,15 +200,23 @@ def flush(events, key, close=false)
     @redis.rpush(key, events)
   end
   # called from Stud::Buffer#buffer_flush when an error occurs
-  def on_flush_error(e)
+  def on_send_error(e)
     @logger.warn("Failed to send backlog of events to Redis",
       :identity => identity,
       :exception => e,
       :backtrace => e.backtrace
     )
+
+    begin
+      @redis.disconnect
+    rescue
+    end
+    sleep @reconnect_interval
     @redis = connect
   end
 
+  alias_method :on_send_error, :on_send_error
+
   def close
     if @batch
       buffer_flush(:final => true)