Skip to content

Commit 293e8e1

Browse files
authored
Merge pull request #54 from log4js-node/mtime-not-birthtime
fix: use mtime instead of birthtime
2 parents 5db9fba + 26894a5 commit 293e8e1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/RollingFileWriteStream.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class RollingFileWriteStream extends Writable {
7979
const stats = fs.statSync(this.filename);
8080
this.state.currentSize = stats.size;
8181
if (this.options.pattern) {
82-
this.state.currentDate = format(this.options.pattern, stats.birthtime);
82+
this.state.currentDate = format(this.options.pattern, stats.mtime);
8383
}
8484
} catch (e) {
8585
//file does not exist, that's fine - move along

test/RollingFileWriteStream-test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const mockFs = require("fs-extra");
1616
const oldStatSync = mockFs.statSync;
1717
mockFs.statSync = fd => {
1818
const result = oldStatSync(fd);
19-
result.birthtime = fakedFsDate;
19+
result.mtime = fakedFsDate;
2020
return result;
2121
};
2222

@@ -137,7 +137,7 @@ describe("RollingFileWriteStream", () => {
137137
after(done => {
138138
s.end(() => {
139139
fs.removeSync(fileObj.dir);
140-
done();
140+
done();
141141
});
142142
});
143143

@@ -335,7 +335,7 @@ describe("RollingFileWriteStream", () => {
335335
after(done => {
336336
s.end(() => {
337337
fs.removeSync(fileObj.dir);
338-
done();
338+
done();
339339
})
340340
});
341341

@@ -742,7 +742,7 @@ describe("RollingFileWriteStream", () => {
742742
after(done => {
743743
s.end(() => {
744744
fs.removeSync(fileObj.dir);
745-
done();
745+
done();
746746
});
747747
});
748748

@@ -795,7 +795,7 @@ describe("RollingFileWriteStream", () => {
795795
after(done => {
796796
s.end(() => {
797797
fs.removeSync(fileObj.dir);
798-
done();
798+
done();
799799
});
800800
});
801801

@@ -851,7 +851,7 @@ describe("RollingFileWriteStream", () => {
851851
after(done => {
852852
s.end(() => {
853853
fs.removeSync(fileObj.dir);
854-
done();
854+
done();
855855
});
856856
});
857857

@@ -911,7 +911,7 @@ describe("RollingFileWriteStream", () => {
911911
after(done => {
912912
s.end(() => {
913913
fs.removeSync(fileObj.dir);
914-
done();
914+
done();
915915
});
916916
});
917917

0 commit comments

Comments
 (0)