wait for rds db to be available, cleanup

Author: steffyP

.github/workflows/cloudpod_release.yml

@@ -38,17 +38,17 @@ jobs:
         run: ls -R
       - name: Prepare Release.txt
         run: |
-          echo "Cloud Pod Release for LocalStack Version ${{ inputs.release-tag || 'latest'}}." > Release.txt
-          echo "Please use the 'release-pod-{database}.zip' you need for your configuration." >> Release.txt
-          echo "By default LocalStack uses the engine 'mariadb'. If you start LocalStack with 'RDS_MYSQL_DOCKER=1', please use the 'mysql' pod." >> Release.txt
+          echo "Cloud Pod of the Sample created with LocalStack Version ${{ inputs.release-tag || 'latest'}}." > Release.txt
+          echo " * Please use the 'release-pod-{database}.zip' you need for your configuration." >> Release.txt
+          echo " * By default LocalStack uses the engine 'mariadb', so you need 'release-pod-mariadb.zip' " >> Release.txt
+          echo " * If you start LocalStack with 'RDS_MYSQL_DOCKER=1', please use the 'mysql' pod ('release-pod-mysql.zip')" >> Release.txt
       - name: Create Release
         id: create_release
         uses: softprops/action-gh-release@v1
         with:
           tag_name: "${{ inputs.release-tag || 'latest'}}"
           name: "Cloud Pod for LocalStack Version '${{ inputs.release-tag || 'latest'}}'"
-          body: "The release features a cloud pod for LocalStack version '${{ inputs.release-tag || 'latest'}}'"
+          body-path: ./Release.txt
           files: |
               ./release-pod-mysql.zip
-              ./release-pod-mariadb.zip
-              Release.txt
+              ./release-pod-mariadb.zip

.github/workflows/test_cloudpods.yml

@@ -57,38 +57,53 @@ jobs:
           LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }}
           LOCALSTACK_VOLUME_DIR: ${{ github.workspace }}/ls_test
           MYSQL_FEATURE_FLAG: ${{ matrix.db }}
+          DEBUG: 1 
+          POD_LOAD_CLI_TIMEOUT: 300
         run: |
           mkdir ls_test
           ls -la ls_test
           docker pull localstack/localstack-pro:${{ matrix.tag }}
           # Start LocalStack in the background
           if [ "mysql" ==  ${MYSQL_FEATURE_FLAG} ]; then
-            DEBUG=1 RDS_MYSQL_DOCKER=1 localstack start -d
+            RDS_MYSQL_DOCKER=1 localstack start -d
           else
-            DEBUG=1 localstack start -d
+            localstack start -d
           fi
           # Wait 30 seconds for the LocalStack container to become ready before timing out
           echo "Waiting for LocalStack startup..."
           localstack wait -t 15
           echo "Startup complete"
       - name: Inject Pod
-        run: localstack pod load file://release-pod.zip
+        run: |
+          localstack pod load file://release-pod.zip
+          state=$(awslocal rds describe-db-instances | jq -r ".DBInstances[0].DBInstanceStatus")
+          while [ "$state" = creating ]; do
+            sleep 1
+            state=$(awslocal rds describe-db-instances | jq -r ".DBInstances[0].DBInstanceStatus")
+          done
       - name: Run Smoke Tests
         run: |
-          awslocal lambda invoke --cli-binary-format raw-in-base64-out --function-name my-lambda-rds-query-helper --payload '{"sqlQuery": "show tables", "secretName":"/rdsinitexample/rds/creds/mysql-01"}' output
+          awslocal lambda invoke --cli-binary-format raw-in-base64-out --function-name my-lambda-rds-query-helper --payload '{"sqlQuery": "show tables", "secretName":"/rdsinitexample/rds/creds/mysql-01"}' output1
           echo "show tables:"
-          cat output
-          awslocal lambda invoke --cli-binary-format raw-in-base64-out --function-name my-lambda-rds-query-helper --payload '{"sqlQuery": "select Author from Books", "secretName":"/rdsinitexample/rds/creds/mysql-01"}' output
+          cat output1
+          awslocal lambda invoke --cli-binary-format raw-in-base64-out --function-name my-lambda-rds-query-helper --payload '{"sqlQuery": "select Author from Books", "secretName":"/rdsinitexample/rds/creds/mysql-01"}' output2
           echo "select Author from Books:"
-          cat output
-          return_status=$(cat output | jq -r .status)
-          if [ "SUCCESS" !=  ${return_status} ]; then
-            echo "unexpected response: ${return_status}"
-            cat output
+          cat output2
+          return_status1=$(cat output1 | jq -r .status)
+          if [ "SUCCESS" !=  ${return_status1} ]; then
+            echo "unexpected response for query1: ${return_status1}"
+            cat output1
+            exit 1
+          fi
+          return_status2=$(cat output2 | jq -r .status)
+          if [ "SUCCESS" !=  ${return_status2} ]; then
+            echo "unexpected response for query2: ${return_status2}"
+            cat output2
             exit 1
           fi
       - name: Show Logs
         if: failure()
         run: |
           localstack logs
-    
+      # TODO add slack notification
+      # add https://github.com/marketplace/actions/keepalive-workflow + adapt commit message https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs