Skip to content

Commit 6b14b1a

Browse files
committed
Fix(eslint-config-typescript): Add typescript parser for react extensions
* the parser was override by babel form eslint-config-react * override optional jsdoc rules from eslint-config-base/optional
1 parent 26a5edf commit 6b14b1a

File tree

3 files changed

+20
-1
lines changed

3 files changed

+20
-1
lines changed

packages/eslint-config-typescript/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export default [
1010
...base,
1111
tsEslint.configs.recommended,
1212
{
13+
name: '@alma-oss/eslint-config-typescript',
1314
settings: {
1415
// Correctly recognize .ts and .d.ts files when checking import paths against the filesystem
1516
'import/resolver': {
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
11
import baseOptional from '@alma-oss/eslint-config-base/optional';
22

3-
export default baseOptional;
3+
export default [
4+
...baseOptional,
5+
{
6+
name: '@alma-oss/eslint-config-typescript/optional',
7+
rules: {
8+
// TS code is mostly self-documented and having JSDoc directives for everything is redundant
9+
// when you can easily infer return values and argument types from the code itself.
10+
'jsdoc/require-jsdoc': 'off',
11+
'jsdoc/require-returns': 'off',
12+
'jsdoc/require-param-type': 'off',
13+
},
14+
},
15+
];

packages/eslint-config-typescript/react.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
import reactConfig from '@alma-oss/eslint-config-react';
22
import globs from '@alma-oss/eslint-config-base/globs';
3+
// eslint-disable-next-line import/no-unresolved
4+
import parser from '@typescript-eslint/parser';
35

46
export default [
57
...reactConfig,
68
{
9+
name: '@alma-oss/eslint-config-typescript/react',
10+
languageOptions: {
11+
parser,
12+
},
713
rules: {
814
'react/jsx-filename-extension': ['error', { extensions: ['.js', '.jsx', '.ts', '.tsx'] }],
915
},

0 commit comments

Comments
 (0)