[Matrix] Add elementwise and trunc casts #512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes llvm#506 This PR is a partner pr to llvm/llvm-project#168915 It should not run until after the llvm pr merges. That way I won't have XFAIL the clang code. It adds 3 types of tests elementwise casts, vector elementwise casts, and trunc casts. It also moves the existing matrix tests into a Matrix folder for better organization.
tex3d
reviewed
Nov 26, 2025
tex3d
approved these changes
Nov 26, 2025
| int2x2 M2 = (int2x2)V; | ||
| const uint COLS = 2; // float2x2 => 2 rows, 2 columns | ||
| uint row = GI / COLS; // 0..1 | ||
| uint col = GI % COLS; // 0..2 |
There was a problem hiding this comment.
nit
Suggested change
| uint col = GI % COLS; // 0..2 | |
| uint col = GI % COLS; // 0..1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #506
This PR is a partner pr to llvm/llvm-project#168915 It should not merge until after the llvm pr merges. That way I won't have XFAIL the clang code.
It adds 3 types of tests elementwise casts, vector elementwise casts,
and trunc casts.
It also moves the existing matrix tests into a Matrix folder for better organization.