[libc++][optional] Applied [[nodiscard]]
#170045
Draft
+195
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-optional
branch
6 times, most recently
from
416db44 to
40cf697
Compare
Contributor
|
@smallp-o-p Would you please review? |
`[[nodiscard]]` should be applied to functions where discarding the return value is most likely a correctness issue. - https://libcxx.llvm.org/CodingGuidelines.html - https://wg21.link/optional
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-optional
branch
from
40cf697 to
ff99ffa
Compare
| // Get the key function ~bad_optional_access() into the dylib | ||
| ~bad_optional_access() _NOEXCEPT override; | ||
| const char* what() const _NOEXCEPT override; | ||
| [[__nodiscard__]] const char* what() const _NOEXCEPT override; |
Contributor
There was a problem hiding this comment.
No change requested. I very wonder why we decided to expose bad_optional_access to old modes. @EricWF
smallp-o-p
reviewed
Dec 1, 2025
Co-authored-by: William Tran-Viet <wtranviet@proton.me>
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-optional
branch
from
fcd651d to
6e305c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[nodiscard]]should be applied to functions where discarding the return value is most likely a correctness issue.