[clang][Interp][NFC] Assert initialization state in invoke{C,D}tor

Author: tbaederr

clang/lib/AST/Interp/InterpBlock.h

@@ -107,6 +107,7 @@ class Block final {
 
   /// Invokes the constructor.
   void invokeCtor() {
+    assert(!IsInitialized);
     std::memset(rawData(), 0, Desc->getAllocSize());
     if (Desc->CtorFn)
       Desc->CtorFn(this, data(), Desc->IsConst, Desc->IsMutable,
@@ -116,6 +117,7 @@ class Block final {
 
   /// Invokes the Destructor.
   void invokeDtor() {
+    assert(IsInitialized);
     if (Desc->DtorFn)
       Desc->DtorFn(this, data(), Desc);
     IsInitialized = false;

clang/lib/AST/Interp/InterpFrame.cpp

@@ -227,6 +227,7 @@ Pointer InterpFrame::getParamPointer(unsigned Off) {
   size_t BlockSize = sizeof(Block) + Desc.second->getAllocSize();
   auto Memory = std::make_unique<char[]>(BlockSize);
   auto *B = new (Memory.get()) Block(S.Ctx.getEvalID(), Desc.second);
+  B->invokeCtor();
 
   // Copy the initial value.
   TYPE_SWITCH(Desc.first, new (B->data()) T(stackRef<T>(Off)));

clang/lib/AST/Interp/InterpState.cpp

@@ -77,7 +77,7 @@ void InterpState::deallocate(Block *B) {
 
     // We moved the contents over to the DeadBlock.
     B->IsInitialized = false;
-  } else {
+  } else if (B->IsInitialized) {
     B->invokeDtor();
   }
 }