Skip to content

Commit 8e8e46a

Browse files
[compiler-rt][sanitizers] Mark three tests as unsupported on Android
These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. Reviewers: vitalybuka, eugenis, thurstond, fmayer Reviewed By: fmayer Pull Request: #166639
1 parent 9a9e3e3 commit 8e8e46a

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

compiler-rt/test/asan/TestCases/log-path_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
2-
// XFAIL: android
3-
// UNSUPPORTED: ios
2+
// UNSUPPORTED: ios, android
43
//
54
// The for loop in the backticks below requires bash.
65
// REQUIRES: shell

compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
// RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t-dir/asan.log.verbose-log-path_test-binary.*
1010

1111
// FIXME: only FreeBSD, NetBSD and Linux have verbose log paths now.
12-
// XFAIL: target={{.*windows-msvc.*}},android
13-
// UNSUPPORTED: ios
12+
// XFAIL: target={{.*windows-msvc.*}}
13+
// UNSUPPORTED: ios, android
1414

1515
#include <stdlib.h>
1616
#include <string.h>

compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// RUN: not %run %t %t-out && FileCheck < %t-out %s
88

99
// REQUIRES: stable-runtime
10-
// XFAIL: android && asan
10+
// UNSUPPORTED: android && asan
1111

1212
#include <sanitizer/common_interface_defs.h>
1313
#include <stdio.h>

0 commit comments

Comments
 (0)